-
Notifications
You must be signed in to change notification settings - Fork 36
Bug fix #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Bug fix #3
Conversation
samelhousseini
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR implements a bug fix by replacing the use of the markdown_rules constant with json_rules to format business rules.
- Importing json_rules instead of markdown_rules
- Formatting the query using json_rules
Reviewed Changes
| File | Description |
|---|---|
| templates/natural_language_to_SQL/src/steps/business_rules_step.py | Replaces markdown_rules with json_rules for formatting the business rules |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
templates/natural_language_to_SQL/src/steps/business_rules_step.py:17
- The change from markdown_rules to json_rules should be verified to ensure that the new json_rules constant supports the expected formatting arguments and produces the required output format.
from src.constants.data_model import json_rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR addresses a bug fix in the business rules step by replacing the incorrect markdown_rules constant with the correct json_rules constant.
- Updated the import from markdown_rules to json_rules in business_rules_step.py.
- Modified the usage of the formatting method to use json_rules instead of markdown_rules.
Reviewed Changes
| File | Description |
|---|---|
| templates/natural_language_to_SQL/src/steps/business_rules_step.py | Replaced markdown_rules with json_rules to ensure proper formatting of business rules query |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (2)
templates/natural_language_to_SQL/src/steps/business_rules_step.py:17
- Verify that the json_rules constant provides the expected format for the business rules process and that corresponding tests have been updated to reflect this change.
from src.constants.data_model import json_rules
templates/natural_language_to_SQL/src/steps/business_rules_step.py:27
- Ensure that using json_rules.format aligns with the requirements of business_rules_prompt and that no unintended formatting issues arise due to the change from markdown_rules.
rules_with_query = json_rules.format(question=data.user_query)
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information