Skip to content

Conversation

@samelhousseini
Copy link
Collaborator

Purpose

  • ...

Does this introduce a breaking change?

[ ] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Collaborator Author

@samelhousseini samelhousseini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug fix

@samelhousseini samelhousseini requested a review from Copilot March 6, 2025 09:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR implements a bug fix by replacing the use of the markdown_rules constant with json_rules to format business rules.

  • Importing json_rules instead of markdown_rules
  • Formatting the query using json_rules

Reviewed Changes

File Description
templates/natural_language_to_SQL/src/steps/business_rules_step.py Replaces markdown_rules with json_rules for formatting the business rules

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

templates/natural_language_to_SQL/src/steps/business_rules_step.py:17

  • The change from markdown_rules to json_rules should be verified to ensure that the new json_rules constant supports the expected formatting arguments and produces the required output format.
from src.constants.data_model import json_rules

@samelhousseini samelhousseini self-assigned this Mar 7, 2025
@samelhousseini samelhousseini requested a review from Copilot March 7, 2025 11:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR addresses a bug fix in the business rules step by replacing the incorrect markdown_rules constant with the correct json_rules constant.

  • Updated the import from markdown_rules to json_rules in business_rules_step.py.
  • Modified the usage of the formatting method to use json_rules instead of markdown_rules.

Reviewed Changes

File Description
templates/natural_language_to_SQL/src/steps/business_rules_step.py Replaced markdown_rules with json_rules to ensure proper formatting of business rules query

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

templates/natural_language_to_SQL/src/steps/business_rules_step.py:17

  • Verify that the json_rules constant provides the expected format for the business rules process and that corresponding tests have been updated to reflect this change.
from src.constants.data_model import json_rules

templates/natural_language_to_SQL/src/steps/business_rules_step.py:27

  • Ensure that using json_rules.format aligns with the requirements of business_rules_prompt and that no unintended formatting issues arise due to the change from markdown_rules.
rules_with_query = json_rules.format(question=data.user_query)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants