Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows nodepool support #507

Merged
merged 16 commits into from
Jan 31, 2023
Merged

Windows nodepool support #507

merged 16 commits into from
Jan 31, 2023

Conversation

MattLeach25
Copy link
Contributor

PR Summary

Added in Windows node support to Bicep and GUI. Condensed user pool into a module to allow easy re-use.

#487

image

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@MattLeach25 MattLeach25 requested a review from Gordonby January 27, 2023 11:11
Gordonby
Gordonby reviewed Jan 27, 2023
View reviewed changes
@Gordonby
Copy link
Collaborator

Updated branch with Windows specific field update logic.

Added a new OS Sku field that lets us support 2022 in addition to the 2019 default.

image

@Gordonby Gordonby changed the title Ml windows Windows nodepool support Jan 27, 2023
@Gordonby Gordonby added the test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge label Jan 30, 2023
@Gordonby
Copy link
Collaborator

Added a UI warning for Ingress Controller when using Windows Node pools

image

@Gordonby Gordonby temporarily deployed to csu January 30, 2023 18:57 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu January 30, 2023 19:09 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu January 30, 2023 19:15 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu January 30, 2023 19:19 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu January 31, 2023 14:45 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu January 31, 2023 14:49 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu January 31, 2023 15:15 — with GitHub Actions Inactive
@Gordonby Gordonby temporarily deployed to csu January 31, 2023 15:21 — with GitHub Actions Inactive
@MattLeach25 MattLeach25 enabled auto-merge (squash) January 31, 2023 16:56
@MattLeach25 MattLeach25 merged commit d83e386 into main Jan 31, 2023
@MattLeach25 MattLeach25 deleted the ml-windows branch January 31, 2023 17:16
@Gordonby Gordonby mentioned this pull request Jul 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gordonby Gordonby Gordonby approved these changes

Assignees

@MattLeach25 MattLeach25

Labels
helper-ui test-deploy-byoconfig A PR flag to make sure that the BYO-vnet deployment is run before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MattLeach25 @Gordonby