Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Acknowledge Cilium Network Policy #537

Merged
merged 7 commits into from
Mar 16, 2023
Merged

Acknowledge Cilium Network Policy #537

merged 7 commits into from
Mar 16, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Mar 13, 2023 •
edited
Loading

PR Summary

Closes #535

Adds Cilium to the list of network policy providers
Adds logic to prevent Azure or Calico being used if the Cilium dataplane is enabled

image

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby Gordonby requested a review from khowling March 13, 2023 11:31
@Gordonby Gordonby self-assigned this Mar 13, 2023
@Gordonby Gordonby enabled auto-merge (squash) March 13, 2023 11:39
@Gordonby Gordonby disabled auto-merge March 15, 2023 12:22
@Gordonby Gordonby enabled auto-merge (squash) March 16, 2023 08:00
khowling
khowling approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@khowling khowling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff!

@Gordonby Gordonby merged commit f9b3eac into main Mar 16, 2023
@Gordonby Gordonby deleted the gb-ciliumfix branch March 16, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khowling khowling khowling approved these changes

Assignees

@Gordonby Gordonby

Labels
helper-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't find a way to enable Cilium?
2 participants
@Gordonby @khowling