Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for BYO Managed Identity & staged deployment sample #541

Merged
merged 13 commits into from
Mar 20, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Mar 15, 2023

PR Summary

Closes #536

  1. Adds support for bringing your own cluster identity. Useful for when the deploying user has insufficient permissions to create role assignments in the subscription.
  2. Includes a sample for a staged deployment to fully illustrate the roles and responsibilities of a staged "byo" deployment.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue

@Gordonby Gordonby self-assigned this Mar 15, 2023
Gordon Byers added 2 commits March 15, 2023 14:28
@Gordonby Gordonby changed the title Adds support for BYO Managed Identity Adds support for BYO Managed Identity & staged deployment sample Mar 15, 2023
@Gordonby Gordonby marked this pull request as ready for review March 16, 2023 12:43
@Gordonby Gordonby marked this pull request as draft March 16, 2023 12:45
@Gordonby Gordonby marked this pull request as ready for review March 16, 2023 14:17
@Gordonby Gordonby enabled auto-merge (squash) March 16, 2023 14:18
@Gordonby Gordonby requested a review from khowling March 16, 2023 14:18
@lenisha lenisha mentioned this pull request Mar 16, 2023
@Gordonby
Copy link
Collaborator Author

As discussed on the triage call, the sample doc in the PR does definitely take the happy path.

I might split this PR into 2.

  1. Adding Byo Identity in the bicep
  2. The sample directory

@Gordonby
Copy link
Collaborator Author

@khowling and I just walked through PR.
I'll run the 3 deployment tests for each identity option, then we're good to approve/merge

@Gordonby
Copy link
Collaborator Author

Gordonby commented Mar 17, 2023

Type Command Result Pic
System az deployment group create -g gordons -f bicep/main.bicep -p resourceName=sysId JustUseSystemPool=true Success image
Create UAI az deployment group create -g gordons -f bicep/main.bicep -p resourceName=createuai JustUseSystemPool=true custom_vnet=true Success image
BYO UAI az identity create -n id-byo-id-gords -g gordons; az deployment group create -g gordons -f bicep/main.bicep -p resourceName=byouai JustUseSystemPool=true custom_vnet=true byoUaiName=id-byo-id-gords Success image image

@khowling - All 3 deployments work great.

@Gordonby Gordonby merged commit 0a1ef8b into main Mar 20, 2023
@Gordonby Gordonby deleted the gb-byoid branch March 20, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support BYO User-Assigned-Managed-Identity
2 participants