Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spot Instances for user pools #611

Merged
merged 13 commits into from
Oct 26, 2023
Merged

Spot Instances for user pools #611

merged 13 commits into from
Oct 26, 2023

Conversation

Gordonby
Copy link
Collaborator

@Gordonby Gordonby commented Jul 9, 2023

PR Summary

Adds support for VM Spot Instances for the user pool.

If using just the system pool then Spot Instances are not allowed, disabled in the UI and excluded from the deployment script generation.

Closes #610

image

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • This PR is ready to merge and is not Work in Progress
  • Link to a filed issue
  • Screenshot of UI changes (if PR includes UI changes)

@Gordonby Gordonby marked this pull request as ready for review July 9, 2023 11:15
@Gordonby
Copy link
Collaborator Author

Gordonby commented Jul 9, 2023

I have had trouble testing this in my subscription because of Spot Instance availability... That's another problem that i'll try and get fixed 🚀

Test with;
az deployment group create -g innerloop --template-file ./bicep/main.bicep --parameters resourceName=az-k8s-ka nodePoolSpot=true aksOutboundTrafficType=natGateway agentVMSize=Standard_DS2_v2 osDiskSizeGB=32 location=eastus

@Gordonby Gordonby enabled auto-merge (squash) August 17, 2023 17:09
@Gordonby Gordonby self-assigned this Aug 17, 2023
@github-actions
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Sep 17, 2023
@github-actions github-actions bot added Keep Open and removed stale An issue that hasn't had a lot of love recently labels Sep 19, 2023
@github-actions
Copy link
Contributor

PR smells stale, no activity for 30 days. Stale Label will be removed if the PR is updated, otherwise closed in a month.

@github-actions github-actions bot added the stale An issue that hasn't had a lot of love recently label Oct 20, 2023
@Gordonby Gordonby removed the stale An issue that hasn't had a lot of love recently label Oct 25, 2023
@Gordonby
Copy link
Collaborator Author

Tested with;

git clone -b gb-spotvm https://github.com/Gordonby/AKS-Construction
cd AKS-Construction/
cd bicep/
bicep build main.bicep
az deployment group create -g innerloop  --template-file main.bicep --parameters resourceName=az-k8s-ka nodePoolSpot=true aksOutboundTrafficType=natGateway agentVMSize=Standard_DS2_v2 osDiskSizeGB=32 location=eastus agentCount=1

Outputs

image image

@Gordonby Gordonby requested a review from pjlewisuk October 26, 2023 09:27
Copy link
Contributor

@pjlewisuk pjlewisuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, happy to merge

@Gordonby Gordonby merged commit 76da013 into Azure:main Oct 26, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Spot instances for User pools
2 participants