Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] remove the admission enforcer, or allow to be disabled at cluster level #4002

Open
thesuperzapper opened this issue Nov 20, 2023 · 2 comments

Comments

@thesuperzapper
Copy link

Is your feature request related to a problem?

Currently, AKS is the only major Kubernetes distribution that mutates ValidatingWebhookConfiguration and MutatingWebhookConfiguration unexpectedly to add additional namespaceNotIn label selectors for control-plane=true and kubernetes.azure.com/managedby=aks.

This behavior is causing countless issues for downstream apps:

Effectively, every major Kubernetes application has to work around this strange behavior so that customers of AKS can use the app, which is putting a large burden on the open-source community, and driving users away from Azure.

Describe the solution you'd like

My preference is that AKS removes the admission enforcer entirely, or at least disables it by default (with a strong warning that using it will likely break software designed for normal Kubernetes distributions).

If that is not possible, I would at the very least appreciate a new config to disable it at the cluster level, so I can recommend users of complex apps with many webhooks (like Kubeflow / deployKF), disable it to avoid all these problems.

Describe alternatives you've considered

Annotating every webhook with admissions.enforcer/disabled: "true", possibly by using another webhook.

@thesuperzapper thesuperzapper added the feature-request Requested Features label Nov 20, 2023
@thesuperzapper
Copy link
Author

@gambtho @robbiezhang I could not reply to you in #1771 (comment), so I am raising this issue here.

@monotek
Copy link

monotek commented Feb 23, 2024

The ongoing cycle of webhook modifications are impacting the stability of the AKS Kubernetes API.

So this AKS feature contradicts the intended purpose of "protecting system stability" and is having the opposite effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants