Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Differences for Certain Fields in Cert Manager to Stop AKS Sync Loop in ArgoCD #979

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

IamTamika
Copy link
Contributor

@IamTamika IamTamika commented Aug 14, 2024

Description:
This pull request addresses an issue where ArgoCD was continuously syncing changes on an AKS cluster due to differences detected in certain fields managed by Cert Manager.

Problem:
ArgoCD was entering a sync loop due to changes detected in specific fields of Cert Manager resources, particularly in the status and webhook fields of ValidatingWebhookConfiguration objects. These fields are often updated automatically by aks, causing unnecessary sync operations.

Solution:
To prevent this sync loop, the following changes have been implemented:

Added ignoreDifferences configuration in the ArgoCD Application manifest to ignore changes in the webhook fields of ValidatingWebhookConfiguration deployed by the Cert Manager app.
Used jqPathExpressions to specify the paths that should be ignored by ArgoCD during the comparison.

Impact:
This change will stop ArgoCD from unnecessarily syncing changes when these specific fields are updated, reducing sync noise and preventing potential issues in the AKS environment.

Testing:
Verified the ArgoCD sync behavior with the updated ignoreDifferences configuration.
Ensured that no unintended differences are ignored, keeping the sync process accurate and effective.
By submitting this Pull Request, you agree to follow our
Code of Conduct

  • I agree to follow this CNDI's Code of Conduct

Notes (Optional)

cert-manager/cert-manager#4114 (comment)
Azure/AKS#4002

@IamTamika IamTamika self-assigned this Aug 14, 2024
@IamTamika IamTamika marked this pull request as ready for review August 14, 2024 20:33
@johnstonmatt johnstonmatt merged commit 448ea11 into main Aug 14, 2024
4 checks passed
@johnstonmatt johnstonmatt added the bug Something isn't working label Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants