Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 01/22/2023 -01/29/2023 #3445

Merged
merged 6 commits into from
Feb 6, 2023
Merged

Conversation

miwithro
Copy link
Contributor

No description provided.

* Features
* New k8s patch versions for 1.23: Added 1.23.15, removed 1.23.8
* Preview Feature
* Azure CNI Overlay now available in uksouth, australiaeast
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have the docs been updated @phealy ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs have been updated.

CHANGELOG.md Outdated
* AKS now allows updating httpProxyConfig.noProxy after cluster deployment. This updates the webhook which automatically injects environment variables into pods. It does not yet update noProxy configuration on running nodes. New nodepools or VMSS model upgrades will update noProxy on the nodes. In the future, rolling nodes may become automatic.
* Component Updates
* Container Insights addon upgraded to[ciprod01182023](https://dev.azure.com/msazure/CloudNativeCompute/_git/aks-rp/pullrequest/7484271).
* Azure NPM-V2 addon upgaded to [v1.4.32](https://github.com/Azure/azure-container-networking/releases/tag/v1.4.32) in SOV Clouds.
Copy link
Member

@palma21 palma21 Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should should be NPM? (v2 is just an internal qualifier?)
Also this is just for sov clouds?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes just for Sov clouds.

CHANGELOG.md Outdated
* Preview Feature
* Azure CNI Overlay now available in uksouth, australiaeast
* Behavior Change
* AKS now allows updating httpProxyConfig.noProxy after cluster deployment. This updates the webhook which automatically injects environment variables into pods. It does not yet update noProxy configuration on running nodes. New nodepools or VMSS model upgrades will update noProxy on the nodes. In the future, rolling nodes may become automatic.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are docs updated for this? because in docs right now, it's still saying "noProxy can't be changed after cluster creation"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doc update is forthcoming.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

That description is both too low level and not detailed enough. Also this is a feature, not a behavior change.

AKS now allows updating the noProxy value of HTTP Proxy configuration after cluster deployment. This will automatically inject new environment variables into pods with the new noProxy values. Pods must be rotated for the apps to pick it up. For components under kubernetes, like containerd and the node itself this won't take effect until a node image upgrade is performed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well technically, we are changing the behavior of an http proxy to allow update, which removes a limitation

CHANGELOG.md Outdated
* Preview Feature
* Azure CNI Overlay now available in uksouth, australiaeast
* Behavior Change
* AKS now allows updating httpProxyConfig.noProxy after cluster deployment. This updates the webhook which automatically injects environment variables into pods. It does not yet update noProxy configuration on running nodes. New nodepools or VMSS model upgrades will update noProxy on the nodes. In the future, rolling nodes may become automatic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes on this

CHANGELOG.md Outdated
* Behavior Change
* AKS now allows updating httpProxyConfig.noProxy after cluster deployment. This updates the webhook which automatically injects environment variables into pods. It does not yet update noProxy configuration on running nodes. New nodepools or VMSS model upgrades will update noProxy on the nodes. In the future, rolling nodes may become automatic.
* Component Updates
* Container Insights addon upgraded to[ciprod01182023](https://dev.azure.com/msazure/CloudNativeCompute/_git/aks-rp/pullrequest/7484271).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing space

@ghost
Copy link

ghost commented Feb 1, 2023

@Azure/aks-pm issue needs labels

CHANGELOG.md Outdated

* Features
* New k8s patch versions for 1.23: Added 1.23.15, removed 1.23.8
* HTTP Proxy now allows updating the "No Proxy" configuration after cluster deployment.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the description of the change and the caveats now (and no link to doc to further explain, see my comment proposal and/or link to doc)

@miwithro miwithro requested a review from palma21 February 1, 2023 22:32
@miwithro miwithro merged commit 304ef21 into Azure:master Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants