🪲 Bug Report - Parameter file contains incorrect parameter

[JokeF]

Describe the bug

The mgDiagSettings module has a parameter file https://github.com/Azure/ALZ-Bicep/blob/85701affdd84a8b9b271948fac8bc56feac2a3b0/infra-as-code/bicep/modules/mgDiagSettings/parameters/mgDiagSettings.parameters.all.json which contains the parameter "parTargetManagementGroupId"
This parameter isn't used in the bicep template and the deployment of the module fails.

If running the orchestration module another parameter file is used and there is no issue.

To Reproduce

Steps to reproduce the behaviour:

1. Fill the parameter file \infra-as-code\bicep\modules\logging\parameters\logging.parameters.all.json
2. Run the module
   New-AzResourceGroupDeployment -ResourceGroupName "rg-alz-logging-001" -TemplateFile .\infra-as-code\bicep\modules\logging\logging.bicep -TemplateParameterFile .\infra-as-code\bicep\modules\logging\parameters\logging.parameters.all.json
3. Error occurs

Expected behaviour

The template to be deployed by the Azure Resource Manager

Proposed fix

Remove parameter from the parameter file

[jtracey93]

Hey @JokeF, thanks for raising.

I'm assuming the references to the logging module here are incorrect and a typo - let me know if not.

As for the mgDiagSettings module you have indeed found a small bug here, which we will fix soon.

However, I'd like to point out that as per our Deployment Flow Wiki page we suggest to use the mgDiagSettingsAll module instead as this does it on all the ALZ management groups in one go 👍

Please use this module instead for now or remove the un-required parameter as a workaround until will resolve in a PR.

Thanks

Jack