Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure backup DNS zone geo code fix and docs #280

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

jtracey93
Copy link
Contributor

@jtracey93 jtracey93 commented Jul 7, 2022

Overview/Summary

Azure backup DNS zone geo code fix and docs

This PR fixes/adds/changes/removes

  1. Updates privateDnsZone & hubNetworking module
  2. Fixes 🪲 Bug Report - Azure Backup Private DNS Zones for Private Link Missing Geo Codes #279

Breaking Changes

Old Azure Backup Private DNS zone will need to be manually removed by users but new, correct, DNS zone will be created on incremental deployments.

Testing Evidence

Linting & Unit Tests will suffice

image

image

As part of this Pull Request I have

@jtracey93 jtracey93 requested a review from jfaurskov July 7, 2022 15:49
@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Jul 7, 2022
@jtracey93
Copy link
Contributor Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 removed the Needs: Triage 🔍 Needs triaging by the team label Jul 7, 2022
@jtracey93
Copy link
Contributor Author

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 requested a review from ejhenry July 7, 2022 17:52
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be missing a dns namespace in hubnetworking module

@jtracey93 jtracey93 requested a review from jfaurskov July 8, 2022 08:34
Copy link
Contributor

@jfaurskov jfaurskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtracey93 jtracey93 merged commit 754ba2c into Azure:main Jul 8, 2022
@jtracey93 jtracey93 deleted the fix-279-pdns-az-backup branch July 8, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🪲 Bug Report - Azure Backup Private DNS Zones for Private Link Missing Geo Codes
2 participants