-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update json file loading to use loadJsonContent #343
Update json file loading to use loadJsonContent #343
Conversation
Hey KevinRabun, thanks for creating this PR. We noticed that this PR is ammending some things related to policies (definitions or assignments) 🔍 Thanks for this however, please keep in mind we replicate all policies from our upstream repo https://github.com/Azure/Enterprise-Scale (via some GitHub Actions) into these Bicep modules. So it may be that this PR may be closed and we ask you to re-submit the changes to the respective code in our other repo. However, we will review and advise further anyway but this is just a friendly premptive message and reminder of how policies are used and updated in this repo. Thanks from your friendly msft-bot. |
@jtracey93 I removed the files we spoke update and updated this PR. I'll keep an eye on the linter though to make sure it is happy. |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Overview/Summary
Updated json file loading to use loadJsonContent instead of json(loadTextContent. This approach allows for roughly 8x larger json files to be loaded by Bicep.
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
I made this change already in the SLZ variant of ALZ and successfully deployed the environment.
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch