-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy-VM-Backup optional parameters for exclusion tag #482
Conversation
Adding optional parameters for Deploy-VM-Backup to exclude VMs with specific tag and value(s)
Adding new optional parameters for VM backup exclusions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great @stalejohnsen, thanks for the contribution and effort here.
Can I ask that you manually generate the parameter docs updates and push the changes into your branch by following: https://github.com/Azure/ALZ-Bicep/wiki/Contributing#manually-generating-the-parameter-markdown-files
Thanks
Jack
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will finish tests and then merge
Updated Markdown generated for alzDefaultPolicyAssignments.bicep and included in this branch. |
Overview/Summary
The ALZ default policy 'Deploy-VM-Backup' has the name 'Configure backup on virtual machines without a given tag to a new recovery services vault with a default policy'. In the current implementation of alzDefaultPolicyAssignments module it is not possible to set an exclusion tag as parameter, hence it is not possible to do what the policy name is describing as functionality.
This PR fixes/adds/changes/removes
Breaking Changes
No breaking changes, this is optional parameters
Testing Evidence
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch