Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26294: Accelerator Pipeline Adjustments #487

Merged
merged 7 commits into from
Apr 4, 2023
Merged

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Apr 4, 2023

Overview/Summary

General fixes and adjustments after testing with ALZ PowerShell Module.0.1.3

This PR fixes/adds/changes/removes

  1. Related to AB#26294
  2. Moved resource group deployment scripts values to GitHub Action environment variables to reduce amount of spots end-user needs to modify.
  3. Fixing workflow path trigger reference to point to vwan param file instead of hub param file.
  4. Added condition to check for existing custom module bicep files prior to attempting to run the bicep build action.

Breaking Changes

  1. No breaking changes for ALZ PWSH module as no file paths have been changed.

Testing Evidence

Resource Group Deployment Changes
image
image

PR-1 Workflow changes
image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 4, 2023
@oZakari oZakari marked this pull request as ready for review April 4, 2023 03:47
@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 4, 2023
@jtracey93 jtracey93 merged commit 1ccf0a7 into Azure:main Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants