Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADO 27172 - Add Zero Trust Networking Telemetry - Phase 1 #508

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

jtracey93
Copy link
Contributor

@jtracey93 jtracey93 commented Apr 26, 2023

Overview/Summary

Adds additional telemetry deployments if certain resources are deployed in the modules that indicate customers is adopting Zero Trust Networking principles. It also still honours the disabling of telemetry via the parameter parTelemetryOptOut.

This PR fixes/adds/changes/removes

  1. AB#27172

Breaking Changes

None

Testing Evidence

Tested complex ternary inputs with the below code:

targetScope = 'tenant'

param parVirtualWanHubs array = [ {
    parVpnGatewayEnabled: true
    parExpressRouteGatewayEnabled: true
    parAzFirewallEnabled: true
    parVirtualHubAddressPrefix: '10.100.0.0/23'
    parHubLocation: 'eastus'
    parHubRoutingPreference: 'ExpressRoute' //allowed values are 'ASN','VpnGateway','ExpressRoute'.
    parVirtualRouterAutoScaleConfiguration: 2 //minimum capacity should be between 2 to 50
  }
  {
    parVpnGatewayEnabled: true
    parExpressRouteGatewayEnabled: true
    parAzFirewallEnabled: false
    parVirtualHubAddressPrefix: '10.200.0.0/23'
    parHubLocation: 'uksouth'
    parHubRoutingPreference: 'ExpressRoute' //allowed values are 'ASN','VpnGateway','ExpressRoute'.
    parVirtualRouterAutoScaleConfiguration: 2 //minimum capacity should be between 2 to 50
  }
  {
    parVpnGatewayEnabled: true
    parExpressRouteGatewayEnabled: true
    parAzFirewallEnabled: true
    parVirtualHubAddressPrefix: '10.1.0.0/23'
    parHubLocation: 'uksouth'
    parHubRoutingPreference: 'ExpressRoute' //allowed values are 'ASN','VpnGateway','ExpressRoute'.
    parVirtualRouterAutoScaleConfiguration: 2 //minimum capacity should be between 2 to 50
  }
]

var varCombined = !(contains(map(parVirtualWanHubs, hub => hub.parAzFirewallEnabled), false)) ? true : false

output outFinal bool = varCombined

And outputs correct bool value when all parAzFirewallEnabled property values are true

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 26, 2023
@jtracey93 jtracey93 added enhancement and removed Needs: Triage 🔍 Needs triaging by the team labels Apr 26, 2023
@jtracey93
Copy link
Contributor Author

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DaFitRobsta DaFitRobsta merged commit f54bf8b into main Apr 26, 2023
@DaFitRobsta DaFitRobsta deleted the add-ztn-telemetry branch April 26, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants