Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

25520 - Azfw Basic SKU #510

Merged
merged 18 commits into from
May 3, 2023
Merged

25520 - Azfw Basic SKU #510

merged 18 commits into from
May 3, 2023

Conversation

4pplied
Copy link
Contributor

@4pplied 4pplied commented Apr 28, 2023 •
edited by jtracey93
Loading

Overview/Summary

AB#25520

Adding support for Azure Firewall Basic SKU to ALZ Bicep.

This PR fixes/adds/changes/removes

  1. Support to Azure Firewall Basic SKU in HubNetworking and VwanConectivity modules
  2. Fixes Daily Bicep Build & Lint Worklfow Failed  #515

Breaking Changes

  1. N/A

Testing Evidence

HubNetworking module WITH basic:

image

image

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label Apr 28, 2023
@ghost ghost removed the Needs: Author Feedback label Apr 28, 2023
@4pplied
Copy link
Contributor Author

4pplied commented Apr 29, 2023

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@4pplied
Copy link
Contributor Author

4pplied commented Apr 29, 2023

/azp run e2e

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@4pplied
Copy link
Contributor Author

4pplied commented May 2, 2023

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@4pplied
Copy link
Contributor Author

4pplied commented May 2, 2023

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@4pplied
Copy link
Contributor Author

4pplied commented May 2, 2023

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels May 2, 2023
@4pplied
Copy link
Contributor Author

4pplied commented May 2, 2023

/azp run validateazcloud

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jtracey93 jtracey93 merged commit 5badfdd into Azure:main May 3, 2023
@jtracey93 jtracey93 mentioned this pull request May 3, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtracey93 jtracey93 jtracey93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Daily Bicep Build & Lint Worklfow Failed
2 participants
@4pplied @jtracey93