Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Tweaks #521

Merged
merged 3 commits into from
May 3, 2023
Merged

Minor Tweaks #521

merged 3 commits into from
May 3, 2023

Conversation

jtracey93
Copy link
Contributor

@jtracey93 jtracey93 commented May 3, 2023 •
edited
Loading

Overview/Summary

Remove some breaking changes

This PR fixes/adds/changes/removes

  1. Add ServiceMap back to allowed values in logging module to remove breaking change
  2. Add new variable in hubNetworking module to allow missing properties in parSubnets added recently

Breaking Changes

None

Testing Evidence

Tested data model locally and working as expected

As part of this Pull Request I have

@ghost ghost added the Needs: Triage 🔍 Needs triaging by the team label May 3, 2023
@jtracey93 jtracey93 added Area: Networking and removed Needs: Triage 🔍 Needs triaging by the team labels May 3, 2023
@jtracey93 jtracey93 merged commit cc58ddd into main May 3, 2023
@jtracey93 jtracey93 deleted the fixes-quick branch May 3, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jtracey93