Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US 31189 - Add BICEPPARAM files to modules #671

Closed
wants to merge 29 commits into from
Closed

US 31189 - Add BICEPPARAM files to modules #671

wants to merge 29 commits into from

Conversation

4pplied
Copy link
Contributor

@4pplied 4pplied commented Oct 31, 2023

Overview/Summary

PR to add BICEPPARAM files in co-existence with JSON parameter files. Also added Code snippets into Markdowns.

AB#31189

This PR fixes/adds/changes/removes

  1. Added BICEPPARAM files into the same folder as the JSON parameters for each respective module

Breaking Changes

  1. N/A

Testing Evidence

image

As part of this Pull Request I have

@4pplied 4pplied changed the title Bicepparams US 31189 - Add BICEPPARAM files to modules Oct 31, 2023
@oZakari oZakari self-assigned this Oct 31, 2023
@oZakari
Copy link
Contributor

oZakari commented Oct 31, 2023

Thanks @appli3d, I'll go over this tomorrow morning.

@picccard
Copy link
Contributor

picccard commented Nov 3, 2023

Wow great stuff @appli3d!

Have you done any testing with bicepparam files located in the config/custom-parameters folder as per the accelerator folder-structure?

Any bicepparam there would have to start with using '../../upstream-versions/v0.16.6/infra-as-code/...'
So how would upgrading to any newer release be handled? All bicepparams would be manually updated or could the env:UPSTREAMVERSION be used there?

@oZakari
Copy link
Contributor

oZakari commented Nov 7, 2023

Looking through some of the tests to make sure we don't need exclude or adjust any existing tests but so far looks good. @appli3d

@oZakari
Copy link
Contributor

oZakari commented Nov 7, 2023

Hi @picccard! We are looking in transitioning the Accelerator to the bicepparam files in the next couple of months. You should be able to transition your existing json parameter files within the Accelerator, but would have to adjust the using statement from the ones included in this PR.

@oZakari
Copy link
Contributor

oZakari commented Nov 13, 2023

Holding off on merging this until we sort the Accelerator out and I will keep in-sync until then.

@oZakari
Copy link
Contributor

oZakari commented Nov 20, 2023

Holding off on Bicep params until we get updates from PG on whether they decide to remove the using statements.

@oZakari oZakari closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants