-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US 31189 - Add BICEPPARAM files to modules #671
Conversation
Thanks @appli3d, I'll go over this tomorrow morning. |
Wow great stuff @appli3d! Have you done any testing with bicepparam files located in the config/custom-parameters folder as per the accelerator folder-structure? Any bicepparam there would have to start with using '../../upstream-versions/v0.16.6/infra-as-code/...' |
Looking through some of the tests to make sure we don't need exclude or adjust any existing tests but so far looks good. @appli3d |
Hi @picccard! We are looking in transitioning the Accelerator to the bicepparam files in the next couple of months. You should be able to transition your existing json parameter files within the Accelerator, but would have to adjust the using statement from the ones included in this PR. |
Holding off on merging this until we sort the Accelerator out and I will keep in-sync until then. |
Holding off on Bicep params until we get updates from PG on whether they decide to remove the using statements. |
Overview/Summary
PR to add BICEPPARAM files in co-existence with JSON parameter files. Also added Code snippets into Markdowns.
AB#31189
This PR fixes/adds/changes/removes
Breaking Changes
Testing Evidence
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch