Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing DNS zones to policy assignment #933

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Jan 7, 2025

Overview/Summary

This pull request includes significant changes to the alzDefaultPolicyAssignments.bicep file to add multiple new Azure Private DNS Zone IDs. These changes enhance the module's capability to manage a broader range of Azure services.

The most important changes include:

  • Added azureMachineLearningWorkspaceSecondPrivateDnsZoneId to support a second private DNS zone for Azure Machine Learning Workspace.
  • Added azureMediaServicesLivePrivateDnsZoneId, azureMediaServicesStreamPrivateDnsZoneId, and azureMigratePrivateDnsZoneId to support additional private DNS zones for Azure Media Services and Azure Migrate.
  • Added multiple azureMonitorPrivateDnsZoneId entries (from azureMonitorPrivateDnsZoneId2 to azureMonitorPrivateDnsZoneId5) to support additional private DNS zones for Azure Monitor.
  • Added azureServiceBusNamespacePrivateDnsZoneId and azureSignalRPrivateDnsZoneId to support private DNS zones for Azure Service Bus and Azure SignalR.
  • Added several azureStorage related private DNS zone IDs, including azureStorageBlobPrivateDnsZoneId, azureStorageQueuePrivateDnsZoneId, and azureStorageTablePrivateDnsZoneId, among others, to

This PR fixes/adds/changes/removes

  1. Adds missing DNS zones to policy assingment

Breaking Changes

  1. None

Testing Evidence

image

As part of this Pull Request I have

@oZakari oZakari temporarily deployed to BicepUpdateDocumentation January 7, 2025 00:40 — with GitHub Actions Inactive
@oZakari oZakari added Area: Policy 📝 Issues / PR's related to Policy Type: Bug 🪲 Something isn't working labels Jan 7, 2025
@oZakari
Copy link
Contributor Author

oZakari commented Jan 7, 2025

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari oZakari merged commit c540c63 into main Jan 7, 2025
23 checks passed
@oZakari oZakari deleted the fix-policy-assignment branch January 7, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Type: Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant