Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate RP from Azure AD Graph to Microsoft Graph #1970

Merged
merged 12 commits into from
Jun 14, 2023

Commits on Jun 8, 2023

  1. Configuration menu
    Copy the full SHA
    5125f08 View commit details
    Browse the repository at this point in the history
  2. azureclient: Add NewGraphServiceClient

    Creates a GraphServiceClient with scope and graph endpoint set
    appropriately for the cloud environment (public or US government).
    mbarnes committed Jun 8, 2023
    Configuration menu
    Copy the full SHA
    8729401 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. Configuration menu
    Copy the full SHA
    25fee28 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e9765db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    96d3a73 View commit details
    Browse the repository at this point in the history
  4. Use MS Graph endpoint to validate service principal

    I don't think it matters for the purpose of validation, but the
    AD Graph endpoint is nearing its end-of-life.
    mbarnes committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b9e878c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    6de830a View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    bcb2cb9 View commit details
    Browse the repository at this point in the history
  7. Pretty-print OData errors from MS Graph

    To aid debugging failed MS Graph requests.
    
    MS Graph's top-level APIError message is hard-coded and only says
    "error status code received from the API".  Further details have
    to be extracted from the "ODataErrorable" interface type.
    mbarnes committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    7257d6c View commit details
    Browse the repository at this point in the history
  8. azureclient: Remove ActiveDirectoryGraphScope

    No longer used.
    mbarnes committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    5af68ff View commit details
    Browse the repository at this point in the history
  9. Remove pkg/util/azureclient/graphrbac

    No longer used.
    mbarnes committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    dd4f4a6 View commit details
    Browse the repository at this point in the history
  10. pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool

    Vendoring the Microsoft Graph SDK for Go causes memory consumption
    during CodeQL analysis to double due to its enormous API surface,
    putting it well beyond the memory limit of standard GitHub Action
    runners.
    
    I inquired with the Azure organization admins about provisioning
    larger GitHub runners, but was directed instead to use the 1ES
    Hosted Pool which runs our other CI checks. Since ARO controls
    the VM type for Hosted Pool agents, we can use a VM type with
    adequate memory for CodeQL analysis with the Graph SDK.
    
    Note: Implemented CodeQL commands in a template in case we
          ever decide to move Javascript or Python analysis to
          1ES Hosted Pool as well.
    mbarnes committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    643ff9e View commit details
    Browse the repository at this point in the history