-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate RP from Azure AD Graph to Microsoft Graph #1970
Merged
Merged
Commits on Jun 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 5125f08 - Browse repository at this point
Copy the full SHA 5125f08View commit details -
azureclient: Add NewGraphServiceClient
Creates a GraphServiceClient with scope and graph endpoint set appropriately for the cloud environment (public or US government).
Configuration menu - View commit details
-
Copy full SHA for 8729401 - Browse repository at this point
Copy the full SHA 8729401View commit details
Commits on Jun 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 25fee28 - Browse repository at this point
Copy the full SHA 25fee28View commit details -
Configuration menu - View commit details
-
Copy full SHA for e9765db - Browse repository at this point
Copy the full SHA e9765dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96d3a73 - Browse repository at this point
Copy the full SHA 96d3a73View commit details -
Use MS Graph endpoint to validate service principal
I don't think it matters for the purpose of validation, but the AD Graph endpoint is nearing its end-of-life.
Configuration menu - View commit details
-
Copy full SHA for b9e878c - Browse repository at this point
Copy the full SHA b9e878cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6de830a - Browse repository at this point
Copy the full SHA 6de830aView commit details -
Configuration menu - View commit details
-
Copy full SHA for bcb2cb9 - Browse repository at this point
Copy the full SHA bcb2cb9View commit details -
Pretty-print OData errors from MS Graph
To aid debugging failed MS Graph requests. MS Graph's top-level APIError message is hard-coded and only says "error status code received from the API". Further details have to be extracted from the "ODataErrorable" interface type.
Configuration menu - View commit details
-
Copy full SHA for 7257d6c - Browse repository at this point
Copy the full SHA 7257d6cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5af68ff - Browse repository at this point
Copy the full SHA 5af68ffView commit details -
Configuration menu - View commit details
-
Copy full SHA for dd4f4a6 - Browse repository at this point
Copy the full SHA dd4f4a6View commit details -
pipelines: Run CodeQL analysis for Go on 1ES Hosted Pool
Vendoring the Microsoft Graph SDK for Go causes memory consumption during CodeQL analysis to double due to its enormous API surface, putting it well beyond the memory limit of standard GitHub Action runners. I inquired with the Azure organization admins about provisioning larger GitHub runners, but was directed instead to use the 1ES Hosted Pool which runs our other CI checks. Since ARO controls the VM type for Hosted Pool agents, we can use a VM type with adequate memory for CodeQL analysis with the Graph SDK. Note: Implemented CodeQL commands in a template in case we ever decide to move Javascript or Python analysis to 1ES Hosted Pool as well.
Configuration menu - View commit details
-
Copy full SHA for 643ff9e - Browse repository at this point
Copy the full SHA 643ff9eView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.