Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DO NOT MERGE] Encryption At Host Dynamic Validation #3826

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[DO NOT MERGE] Encryption At Host Dynamic Validation #3826

wants to merge 1 commit into from

Conversation

SudoBrendan
Copy link
Collaborator

@SudoBrendan SudoBrendan commented Sep 9, 2024 •
edited
Loading

Which issue this PR addresses:

Fixes https://issues.redhat.com/browse/ARO-3837

What this PR does / why we need it:

  • Frontend will now validate that Compute Encryption At Host is enabled on customer's subscription before installing clusters that want to use the feature - this will fix a Cluster Install Failure issue
  • In memory of Swetha. Thanks for your amazing contributions to our team, I'm glad we can finally get your work across the line with this one.

Test plan for issue:

  • Unit tests
  • I will perform a manual validation of this, but that will require some effort (a subscription without the feature enabled).

Is there any documentation that needs to be updated for this PR?

N/A fixes a bug

How do you know this will function as expected in production?

Unit tests and manual tests. Since this uses a new First Party Service Principal authorization (GET on Sub features), we should test this out pretty well for Canary as well before moving forward with it to other regions.

@SudoBrendan SudoBrendan mentioned this pull request Sep 9, 2024
Closed
@SudoBrendan
Copy link
Collaborator Author

/azp run ci

@SudoBrendan
Copy link
Collaborator Author

/azp run e2e

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@SudoBrendan
Copy link
Collaborator Author

Adding hold because apparently our FPSP permissions were flagged for being not in use for a substantial time, so we need to redo that effort and rollout the permissions before this can merge.

@SudoBrendan SudoBrendan added the hold Hold label Sep 9, 2024
@SudoBrendan SudoBrendan changed the title Encryption At Host Dynamic Validation [DO NOT MERGE] Encryption At Host Dynamic Validation Sep 9, 2024
@SudoBrendan SudoBrendan force-pushed the sudobrendan/ARO-3211-encryption-at-host-dyn-validation branch 3 times, most recently from b07dc2a to efbfa50 Compare September 10, 2024 01:15
@SudoBrendan @schiruma
Encryption At Host Dynamic Validation
a1b1c09 
- Frontend will now validate that Encryption At Host is enabled on customer's
  subscription before installing clusters
- In memory of Swetha. Thanks for your amazing contributions to our
  team, I'm glad we can finally get your work across the line with this one.

Co-authored-by: Swetha Chirumamilla <schiruma@redhat.com>
@SudoBrendan SudoBrendan force-pushed the sudobrendan/ARO-3211-encryption-at-host-dyn-validation branch from efbfa50 to a1b1c09 Compare September 10, 2024 01:16
@github-actions GitHub Actions
Copy link

Please rebase pull request.

@github-actions github-actions bot added the needs-rebase branch needs a rebase label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam will be requested when the pull request is marked ready for review jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv will be requested when the pull request is marked ready for review bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl will be requested when the pull request is marked ready for review hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas will be requested when the pull request is marked ready for review rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas will be requested when the pull request is marked ready for review petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 will be requested when the pull request is marked ready for review jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker will be requested when the pull request is marked ready for review cblecker is a code owner

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese will be requested when the pull request is marked ready for review cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter will be requested when the pull request is marked ready for review UlrichSchlueter is a code owner

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 will be requested when the pull request is marked ready for review yjst2012 is a code owner

@jaitaiwan jaitaiwan Awaiting requested review from jaitaiwan jaitaiwan will be requested when the pull request is marked ready for review jaitaiwan is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel will be requested when the pull request is marked ready for review anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig will be requested when the pull request is marked ready for review hlipsig is a code owner

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu will be requested when the pull request is marked ready for review tiguelu is a code owner

@SrinivasAtmakuri SrinivasAtmakuri Awaiting requested review from SrinivasAtmakuri SrinivasAtmakuri will be requested when the pull request is marked ready for review SrinivasAtmakuri is a code owner

@mociarain mociarain Awaiting requested review from mociarain mociarain will be requested when the pull request is marked ready for review mociarain is a code owner

@kimorris27 kimorris27 Awaiting requested review from kimorris27 kimorris27 will be requested when the pull request is marked ready for review kimorris27 is a code owner

@tsatam tsatam Awaiting requested review from tsatam tsatam will be requested when the pull request is marked ready for review tsatam is a code owner

@bitoku bitoku Awaiting requested review from bitoku bitoku will be requested when the pull request is marked ready for review bitoku is a code owner

@fahlmant fahlmant Awaiting requested review from fahlmant fahlmant will be requested when the pull request is marked ready for review fahlmant is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
hold Hold needs-rebase branch needs a rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@SudoBrendan