Log MIWI/SP install type to AsyncQoS; also log successful cluster deletions #3934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ventifus
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
cadenmarchese,
UlrichSchlueter,
SudoBrendan,
yjst2012,
jaitaiwan,
anshulvermapatel,
hlipsig,
tiguelu,
SrinivasAtmakuri,
mociarain,
kimorris27,
tsatam,
bitoku and
fahlmant
as code owners
|
/azp run ci,e2e |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
In the e2e logs for deletion, it does not appear to delete via backend operation, so it's not testing this change. |
edisonLcardenas
previously approved these changes
Nov 5, 2024
bitoku
previously approved these changes
Nov 7, 2024
|
Please rebase pull request. |
ventifus
force-pushed
the
ventifus/ARO-11772-log-delete-completion
branch
from
16a54b5 to
8b8aecf
Compare
|
/azp run e2e,ci |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ventifus
changed the title
cadenmarchese
approved these changes
Jan 24, 2025
cadenmarchese
added
next-release
s-fairchild
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes https://issues.redhat.com/browse/ARO-11772
Enables https://issues.redhat.com/browse/ARO-7841
What this PR does / why we need it:
For dashboarding purposes, we're missing a few things:
We wish to include cluster deletion success/failure rates in a dashboard. This is not possible because currently we don't log the completion of successful cluster deletions. That's because the logs (and other metrics) get emitted by endLease(), and the lease doesn't get released for deletions because the cluster doc gets deleted instead.
We wish to improve our cluster creation dashboards by distinguishing MIWI clusters installs from Service Principal installs. To do that we need a new field in AsyncQoS that records the cluster identity type requested.
Test plan for issue:
Manual testing will be required, as E2E does not exercise this as part of cluster deletion.
When manually testing, check that the appropriate "long running operation succeeded" log is emitted for cluster creation. Check that "long running operation succeeded" now gets logged on deletion. Check that the
clusterIdentityfield is emitted in AsyncQoS logs.Is there any documentation that needs to be updated for this PR?
How do you know this will function as expected in production?