Skip to content

Conversation

@rossgrambo
Copy link
Member

No description provided.

zhiyuanliang-ms and others added 7 commits August 13, 2024 10:18
* add secret client option

* update comment

* rename to configure

* use callback configuration pattern

* remove unused package
* increase default maxretries for key vault client to max value

* update minimum secret refresh interval to 1 minute, enforce for refresh all operations as well

* PR comments

* PR comments

* update max retries default for key vault

* update to use sourceid as key in cached secret dictionary

* move retries number to const int

* call invalidate cache with previous setting if current one is null

* add comment explaining number of key vault retries

* pull out utcnow as a variable in for loop in clearcache
Copy link
Member

@avanigupta avanigupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be merged with a merge commit (not squash)

@rossgrambo
Copy link
Member Author

This PR is superseded by #604 since there was a conflict.

@rossgrambo rossgrambo closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants