Fix bug with endpoint failover #680
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
The PR fixes how endpoint failover backoff is applied by ensuring all clients back off after a non-failoverable exception and adds a test validating this behavior.
- Add a unit test to verify all clients back off after a non-failoverable exception during refresh.
- Fix backoff logic to use the current client’s endpoint rather than the previous one.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/Tests.AzureAppConfiguration/Unit/FailoverTests.cs | New test FailOverTests_AllClientsBackedOffAfterNonFailoverableException added |
| src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs | Changed backoff status update to use GetEndpointForClient(currentClient) instead of previousEndpoint |
src/Microsoft.Extensions.Configuration.AzureAppConfiguration/AzureAppConfigurationProvider.cs
Show resolved
Hide resolved
jimmyca15
approved these changes
Jul 15, 2025
zhiyuanliang-ms
approved these changes
Aug 5, 2025
|
@microsoft-github-policy-service agree |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
CLA cannot be agreed. Move to #686 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the provider doesn't backoff all replicas as expected.
Expected
If there are 2 or more endpoints (1 store endpoint and 1+ replicas) and a request to the first endpoint fails with an exception that the provider does not consider "failoverable" (requesting another endpoint will not solve the issue), all endpoints will be backed off with an exponential backoff factoring in 1 failed request. This means the initial backoff will be around the minimum backoff time of 30 seconds.
Actual
If there are 2 or more endpoints (1 store endpoint and 1+ replicas) and a request to the first endpoint fails with an exception that the provider does not consider "failoverable" (requesting another endpoint will not solve the issue), only the current endpoint will be backed off. The backoff is also incorrectly calculated to be longer than expected.