Skip to content

Release notes for 4.0.0-preview2 #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 28, 2024
Merged

Release notes for 4.0.0-preview2 #886

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e01c3f4
FeatureManagement v4 release notes
rossgrambo Jan 11, 2024
55c0c64
Reworked the Variants section, slight teaks to telemetry and cancella…
rossgrambo Jan 17, 2024
d50d9de
Adjusted json to allow for comments
rossgrambo Jan 17, 2024
27e926b
Adds release notes
rossgrambo Mar 14, 2024
b3c99aa
Adds release notes
rossgrambo Mar 14, 2024
cfdc69f
Small update
rossgrambo Mar 14, 2024
84ccf78
Resolving comments
rossgrambo Mar 21, 2024
2f1f4d4
Adds PR links
rossgrambo Mar 22, 2024
63148fb
Adjusts links
rossgrambo Mar 22, 2024
0b2fbc0
Reduced release notes
rossgrambo Mar 28, 2024
1609034
Adjusted bullet point distance
rossgrambo Mar 28, 2024
12bc72d
Remove hash
rossgrambo Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions releaseNotes/Microsoft.Featuremanagement.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,18 @@
# Microsoft.FeatureManagement.AspNetCore
[Source code ][source_code_web] | [Package (NuGet)][package_web] | [Samples][samples_web] | [Product documentation][docs]

## 4.0.0-preview2 - March 7, 2024

### Enchancements
Copy link
Member

@jimmyca15 jimmyca15 Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enhancements


* Use flags to enable different service implementations in dependency injection. ([#39](https://github.com/microsoft/FeatureManagement-Dotnet/issues/39)). See more details [here](https://github.com/microsoft/FeatureManagement-Dotnet/tree/preview?tab=readme-ov-file#variants-in-dependency-injection).
Copy link
Member

@zhenlan zhenlan Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels like we are shifting from providing too much information to providing too little information (or being vague) now. We still want the release notes to be useful to customers. It took real work to explain big features with one or two sentences. I gave it a shot. Please feel free to update.

Added support for variant feature flag-based service provider in dependency injection. It allows different service implementations to be injected automatically for different targeted audiences based on their variant assignment.

* Additional mechanisms to track targeting within telemetry to improve the connection between published events and metrics. ([#409](https://github.com/microsoft/FeatureManagement-Dotnet/issues/409))
Copy link
Member

@zhenlan zhenlan Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to make release notes like a document, but it doesn't mean we don't want customers to understand our release notes. The changes in the linked PRs are not even part of this package. We mentioned nothing about the new packages. Can we explain how the feature you did can benefit customers?

Copy link
Member Author

@rossgrambo rossgrambo Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This concept is a little in the weeds to dig into. The linked issue links to a PR that explains it microsoft/FeatureManagement-Dotnet#350 (comment).

The customer does not receive much benefit from this- it was a change on how we connect dots which were already connectable. But this is a more stable version.

Do you prefer something like:

Introduced middleware and a telemetry property for Targeting Id, which can be used to connect published evaluation events to other emitted telemetry from a given target.

Copy link
Member

@zhenlan zhenlan Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We released two new packages and found "The customer does not receive much benefit from this". We must be missing something :)

(We should create separate file(s) for the release notes.)

* Added support for Net8 applications by adding Net8 as a build target. ([#364](https://github.com/microsoft/FeatureManagement-Dotnet/issues/364))
Copy link
Member

@zhenlan zhenlan Mar 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not that we didn't support .NET 8 applications before this change. By adding .NET 8 to the targeting framework, we make sure this library uses .NET 8 libraries/APIs when users build a .NET 8 application.

Copy link
Member Author

@rossgrambo rossgrambo Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based it off your previous comment: #886 (comment)

We added net8 as a build target which means we will run tests against it. We did also update the external libraries from 7.0 to 8.0. The only customer facing change here is: "we're less likely to break a .net8 app now". I'd argue that's "adding support ...", but as you said that makes it sound like it wasn't supported at all before. What about just "Added better support ..."?

Copy link
Member

@zhenlan zhenlan Apr 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't quote on me. I wasn't using release-notes ready language in all comments :) How about this?

Added support for .NET 8 targeting framework to the Microsoft.FeatureManagement.AspNetCore package.

Copy link
Member Author

@rossgrambo rossgrambo Apr 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me- maybe a small tweak to be:

Added support for .NET 8 target framework to the Microsoft.FeatureManagement.AspNetCore package.


### Breaking Changes

No breaking changes in this release.

## 3.2.0 - February 29, 2024

### Enhancements
Expand Down