Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option for Windows containers #439

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Added option for Windows containers #439

merged 3 commits into from
Apr 16, 2024

Conversation

tulikac
Copy link
Collaborator

@tulikac tulikac commented Apr 5, 2024

Summary

@tulikac tulikac requested a review from btardif April 5, 2024 10:21
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

Preview link: https://antares-blog-staging-pr-439.azurewebsites.net

  • Your changes have been deployed to the preview site. The preview site will update as you add more commits to this branch.
  • The preview site shows any future-dated articles. If you are publishing a future-dated article, it will not show on the production site until the file's specified date.
  • The preview link is shareable, but will be deleted when this pull request is merged or closed.

This is an automated message.

jvano
jvano approved these changes Apr 6, 2024
View reviewed changes
Copy link

@jvano jvano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :shipit:

btardif
btardif requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@btardif btardif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good, just need to remove the /en-us/ segment from URL.

This makes it so that folks get routed to localized content if it exists.

@tulikac
Copy link
Collaborator Author

tulikac commented Apr 16, 2024

Removed en-us

@btardif btardif merged commit 306d431 into master Apr 16, 2024
4 checks passed
@btardif btardif deleted the sidecar-and-webjobs branch April 16, 2024 16:53
@btardif
Copy link
Member

btardif commented Apr 16, 2024

FYI @tulikac , @jvano change is merged 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvano jvano jvano approved these changes

@btardif btardif btardif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tulikac @btardif @jvano