Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand support for management group deployment #718

Merged
merged 9 commits into from
Dec 1, 2022

Conversation

Jefajers
Copy link
Member

Overview/Summary

This PR expands current support for management group creation by accepting user creation of new folders and placement of management group templates in them (one new level is allowed per push).

Logic to validate template content and folder hierarchy matches current management group parent is performed before any deployment.

This PR fixes/adds/changes/removes

  1. Changes AzOpsScope.ps1
  2. Changes New-AzOpsDeployment.ps1
  3. Changes Strings.psd1
  4. Changes Repository.Tests.ps1
  5. Adds microsoft.management_managementgroups-pushmgmttest1id.json
  6. Adds microsoft.management_managementgroups-pushmgmttest2id.json

Breaking Changes

  1. N/A

Testing Evidence

Three automated test cases are added.

  1. Deployment of new management group using template and folder
  2. Check existence of new management group
  3. Deployment of new management group using template and folder at wrong scope and expect failure

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added the enhancement New feature or request label Nov 29, 2022
@Jefajers Jefajers added this to the Release - v1.9.2 milestone Nov 29, 2022
@Jefajers Jefajers requested review from a team as code owners November 29, 2022 11:49
@Jefajers Jefajers temporarily deployed to test November 29, 2022 13:47 Inactive
@Jefajers Jefajers temporarily deployed to test November 30, 2022 19:41 Inactive
@Jefajers Jefajers merged commit 7bdd9a7 into Azure:main Dec 1, 2022
@Jefajers Jefajers deleted the new-managementGroup branch December 1, 2022 11:55
@Jefajers Jefajers mentioned this pull request Dec 19, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants