Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Pull and Push zones information with Az.ResourceGraph #736

Closed
wants to merge 18 commits into from

Conversation

Jefajers
Copy link
Member

@Jefajers Jefajers commented Jan 6, 2023

Overview/Summary

This PR adds:

  • Pull and Push support of resources zones information by switching to Az.ResourceGraph, fixes Public Ip; zones are removed on AzOpsPull command #701.

  • Improved overall performance during Pull by switching to Az.ResourceGraph for policyassignments, policydefinitions, policysetdefinitions resources.

This PR fixes/adds/changes/removes

  1. Adds new function Search-AzOpsAzGraph
  2. Changes order of resource definition pull
  3. Changes to automated tests to cover zones scenario
  4. Removes unnecessary files

Breaking Changes

  1. N/A

Testing Evidence

Automated tests are used to validate new zone information and remaining tests for policy objects validate remaining changes.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers temporarily deployed to test January 6, 2023 20:00 — with GitHub Actions Inactive
@Jefajers Jefajers temporarily deployed to test January 9, 2023 12:57 — with GitHub Actions Inactive
@Jefajers Jefajers temporarily deployed to test January 13, 2023 12:40 — with GitHub Actions Inactive
@woutermation
Copy link

Hi,
Any update on the approval/review stage?
And thanks for fixing the issue

@daltondhcp
Copy link
Contributor

Hi, Any update on the approval/review stage? And thanks for fixing the issue

Sorry for the slow reply. We are currently blocked by #737. Should be fixed by end of this week.

@daltondhcp daltondhcp closed this Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/powershell enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public Ip; zones are removed on AzOpsPull command
3 participants