-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Support for Deletion of custom ARM and Bicep template resource #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefajers
added
bug
Something isn't working
wiki-doc
Improvements or additions to documentation
enhancement
New feature or request
area/powershell
dependencies
labels
Mar 4, 2024
daltondhcp
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/powershell
bug
Something isn't working
dependencies
enhancement
New feature or request
wiki-doc
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This PR expands deletion support from a handfull of AzOps generated templates to include both AzOps generated resource group templates/folders and custom ARM and Bicep templates while bumping module dependencies for
Az.Accounts 2.16.0
andAz.Resources 6.16.0
.Closes #785 and fixes #849, with improved deleted content serialization logic.
Deletion of custom ARM and Bicep template resource is disabled by default. To enable it, set
Core.CustomTemplateResourceDeletion
totrue
. Be aware, once this feature is turned on, AzOps will attempt resource deletion for each identifed resoruce id contained in the template and parameter file, read more in the wiki.Breaking Changes
N/A
Testing Evidence
Testing has been performed to validate deletion logic update in both GitHub and ADO with no known errors. Automated test cases have been added for basic testing of deleting custom templates.
As part of this Pull Request I have
main
branch