Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Support for Deletion of custom ARM and Bicep template resource #861

Merged
merged 49 commits into from
Mar 12, 2024

Conversation

Jefajers
Copy link
Member

@Jefajers Jefajers commented Mar 4, 2024

Overview/Summary

This PR expands deletion support from a handfull of AzOps generated templates to include both AzOps generated resource group templates/folders and custom ARM and Bicep templates while bumping module dependencies for Az.Accounts 2.16.0 and Az.Resources 6.16.0.

Closes #785 and fixes #849, with improved deleted content serialization logic.

Deletion of custom ARM and Bicep template resource is disabled by default. To enable it, set Core.CustomTemplateResourceDeletion to true. Be aware, once this feature is turned on, AzOps will attempt resource deletion for each identifed resoruce id contained in the template and parameter file, read more in the wiki.

Breaking Changes

N/A

Testing Evidence

Testing has been performed to validate deletion logic update in both GitHub and ADO with no known errors. Automated test cases have been added for basic testing of deleting custom templates.

As part of this Pull Request I have

  • Checked for duplicate Pull Requests
  • Associated it with relevant issues, for tracking and closure.
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Performed testing and provided evidence.
  • Updated relevant and associated documentation.

@Jefajers Jefajers added bug Something isn't working wiki-doc Improvements or additions to documentation enhancement New feature or request area/powershell dependencies labels Mar 4, 2024
@Jefajers Jefajers added this to the v2.6.0 milestone Mar 4, 2024
@daltondhcp daltondhcp marked this pull request as ready for review March 11, 2024 15:41
@daltondhcp daltondhcp requested review from a team as code owners March 11, 2024 15:41
Copy link
Contributor

@daltondhcp daltondhcp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Jefajers Jefajers merged commit 350dc96 into Azure:main Mar 12, 2024
4 checks passed
@Jefajers Jefajers deleted the customDeletion branch March 12, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/powershell bug Something isn't working dependencies enhancement New feature or request wiki-doc Improvements or additions to documentation
Projects
Status: Done
2 participants