-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Threat Intelligence Solution #11358
base: master
Are you sure you want to change the base?
Conversation
…e-Sentinel into GoogleThreatIntelligence
Hello @NicoRomero-07, Please update the branch from master once. The checks are stucked |
Solutions/Google Threat Intelligence/Data/Solution_GoogleThreatIntelligence.json
Outdated
Show resolved
Hide resolved
Solutions/Google Threat Intelligence/Playbooks/GTIEnrichment/GTI-EnrichAlert/azuredeploy.json
Outdated
Show resolved
Hide resolved
…ogleThreatIntelligence
Hello @NicoRomero-07, I would suggest to add deployment steps of custom connector in prerequisites of playbooks |
other than this all looks good to me |
Hello @v-prasadboke , |
Hello @NicoRomero-07, you missed on packaging the solution. |
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present:
IDs Should Be Derived From ResourceIDs x2
[-] IDs Should Be Derived From ResourceIDs (38 ms)
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid
These are the ids:
"id": "[variables('_playbookcontentProductId1')]"
"id": "[variables('_solutioncontentProductId')]"
And variables:
"_playbookcontentProductId1": "[concat(take(variables('_solutionId'),50),'-','lc','-', uniqueString(concat(variables('_solutionId'),'-','LogicAppsCustomConnector','-',variables('_playbookContentId1'),'-', variables('playbookVersion1'))))]",
"_solutioncontentProductId": "[concat(take(variables('_solutionId'),50),'-','sl','-', uniqueString(concat(variables('_solutionId'),'-','Solution','-',variables('_solutionId'),'-', variables('_solutionVersion'))))]"
Id definition is using variables, shouldn't that be enough to meet the requirement?