Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Threat Intelligence Solution #11358

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

NicoRomero-07
Copy link

Change(s):

  • New Custom Connector
  • New Playbooks for Enrichment

Reason for Change(s):

  • New Google Threat Intelligence Solution

Version Updated:

  • Yes

Testing Completed:

  • Yes

Checked that the validations are passing and have addressed any issues that are present:

  • Need Help

IDs Should Be Derived From ResourceIDs x2
[-] IDs Should Be Derived From ResourceIDs (38 ms)
Property: "id" must use one of the following expressions for an resourceId property:
extensionResourceId,resourceId,subscriptionResourceId,tenantResourceId,if,parameters,reference,variables,subscription,guid

These are the ids:
"id": "[variables('_playbookcontentProductId1')]"
"id": "[variables('_solutioncontentProductId')]"

And variables:
"_playbookcontentProductId1": "[concat(take(variables('_solutionId'),50),'-','lc','-', uniqueString(concat(variables('_solutionId'),'-','LogicAppsCustomConnector','-',variables('_playbookContentId1'),'-', variables('playbookVersion1'))))]",
"_solutioncontentProductId": "[concat(take(variables('_solutionId'),50),'-','sl','-', uniqueString(concat(variables('_solutionId'),'-','Solution','-',variables('_solutionId'),'-', variables('_solutionVersion'))))]"

Id definition is using variables, shouldn't that be enough to meet the requirement?

@NicoRomero-07 NicoRomero-07 requested review from a team as code owners October 28, 2024 14:54
@v-prasadboke v-prasadboke self-assigned this Oct 29, 2024
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Oct 29, 2024
@v-prasadboke
Copy link
Contributor

Hello @NicoRomero-07, Please update the branch from master once. The checks are stucked

@v-prasadboke
Copy link
Contributor

Hello @NicoRomero-07, I would suggest to add deployment steps of custom connector in prerequisites of playbooks

@v-prasadboke
Copy link
Contributor

other than this all looks good to me

@NicoRomero-07
Copy link
Author

NicoRomero-07 commented Nov 21, 2024

Hello @v-prasadboke ,
In the content hub, the CustomConnector won't appear for users, right? That is, they will have to deploy the custom connector by the URI of the GitHub repository to the azuredeploy.json file. We can make it easier to use by providing a 'Deploy to Azure' button.

@v-prasadboke
Copy link
Contributor

Hello @NicoRomero-07, you missed on packaging the solution.
Can you repackage it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants