Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Proposal]: avm/ptn/azd/insights-dashboard #1206

Closed
2 tasks done
Menghua1 opened this issue Jul 18, 2024 · 10 comments · Fixed by Azure/bicep-registry-modules#3175
Closed
2 tasks done

[Module Proposal]: avm/ptn/azd/insights-dashboard #1206

Menghua1 opened this issue Jul 18, 2024 · 10 comments · Fixed by Azure/bicep-registry-modules#3175
Assignees
Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed

Comments

@Menghua1
Copy link
Member

Menghua1 commented Jul 18, 2024

Check for previous/existing GitHub issues/module proposals

  • I have checked for previous/existing GitHub issues/module proposals.

Check this module doesn't already exist in the module indexes

  • I have checked for that this module doesn't already exist in the module indexes.

Bicep or Terraform?

Bicep

Module Classification?

Pattern Module

Module Name

avm/ptn/azd/insights-dashboard

Module Details

Please add a Pattern Module named avm/ptn/azd/insights-dashboard, this module will create the following two resources:

  1. Application Insights instance based on an existing Log Analytics workspace.
  2. Portal Dashboard for an Application Insights instance.

For details, please refer to azd:
https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/monitor/applicationinsights.bicep

https://github.com/Azure/azure-dev/blob/main/templates/common/infra/bicep/core/monitor/applicationinsights-dashboard.bicep

CC: @jongio

Do you want to be the owner of this module?

No

Module Owner's GitHub Username (handle)

jongio

(Optional) Secondary Module Owner's GitHub Username (handle)

No response

@Menghua1 Menghua1 added Needs: Triage 🔍 Maintainers need to triage still Type: New Module Proposal 💡 A new module for AVM is being proposed labels Jul 18, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Language: Bicep 💪 This is related to the Bicep IaC language Needs: Module Owner 📣 This module needs an owner to develop or maintain it labels Jul 18, 2024
@ChrisSidebotham
Copy link
Contributor

@jongio - Would a suitable owner for this module be identified from your team or do we need to look elsewhere?

@jongio
Copy link
Member

jongio commented Jul 22, 2024

@Menghua1 - Please add more details to this proposal on what this module will do exactly.

@Menghua1
Copy link
Member Author

@jongio I've updated Module Details in the Description.

@jongio
Copy link
Member

jongio commented Jul 23, 2024

@ChrisSidebotham - I can signup to be the owner of this and all azd related pattern modules. What's the best way to do that?

@matebarabas
Copy link
Contributor

Hi @jongio, @jeanchg and I will reach out to you internally once you're back next week to clarify the context and some of our questions on this and all the other related pattern module proposals @Menghua1 has recently submitted.

@matebarabas matebarabas added Status: In Triage 🔍 Picked up for triaging by an AVM core team member Class: Pattern Module 📦 This is a pattern module labels Aug 2, 2024
@matebarabas matebarabas added the AZD 🧑‍💻 These modules are requested/used by the AZD team. label Aug 7, 2024
@Menghua1 Menghua1 changed the title [Module Proposal]: avm/ptn/insights/insights-dashboard [Module Proposal]: avm/ptn/azd/insights-dashboard Aug 22, 2024
@jongio
Copy link
Member

jongio commented Aug 28, 2024

I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

@matebarabas
Copy link
Contributor

Hi @jongio,

Thanks for requesting/proposing to be an AVM module owner!

We just want to confirm you agree to the below pages that define what module ownership means:

Any questions or clarifications needed, let us know!

If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):

"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"

Thanks,

The AVM Core Team

#RR

@Menghua1
Copy link
Member Author

Menghua1 commented Sep 9, 2024

@AlexanderSehr I would like to ask if you know how long it will take for the current module br/public:avm/ptn/azd/insights-dashboard:<version> to be released?

@AlexanderSehr
Copy link
Contributor

@AlexanderSehr I would like to ask if you know how long it will take for the current module br/public:avm/ptn/azd/insights-dashboard:<version> to be released?

I'd argue it is 😉
image

In case it's not showing up for you yet, rest assured it's just a caching issue which will fix itself. You can already reference the module regardless :)

@matebarabas
Copy link
Contributor

  • Module published.
  • GitHub teams are available and assigned to their parents.
  • CODEOWNERS file updated.
  • Issue template file updated.

Thank you for your work @Menghua1!

@matebarabas matebarabas added the Status: Module Available 🟢 The module is published label Sep 9, 2024
Menghua1 added a commit to Menghua1/bicep-registry-modules that referenced this issue Sep 10, 2024
## Description
Fixes Azure/Azure-Verified-Modules#1206.
<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.azd.insights-dashboard](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.insights-dashboard.yml/badge.svg?branch=ptn%2Fazd%2Finsights-dashboard)](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.insights-dashboard.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

@jongio for notification.

---------

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
jianingwang123 pushed a commit to jianingwang123/bicep-registry-modules that referenced this issue Sep 12, 2024
## Description
Fixes Azure/Azure-Verified-Modules#1206.
<!--
>Thank you for your contribution !
> Please include a summary of the change and which issue is fixed.
> Please also include the context.
> List any dependencies that are required for this change.

Fixes Azure#123
Fixes Azure#456
Closes Azure#123
Closes Azure#456
-->

## Pipeline Reference

<!-- Insert your Pipeline Status Badge below -->

| Pipeline |
| -------- |
|
[![avm.ptn.azd.insights-dashboard](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.insights-dashboard.yml/badge.svg?branch=ptn%2Fazd%2Finsights-dashboard)](https://github.com/Menghua1/bicep-registry-modules/actions/workflows/avm.ptn.azd.insights-dashboard.yml)
|

## Type of Change

<!-- Use the checkboxes [x] on the options that are relevant. -->

- [ ] Update to CI Environment or utilities (Non-module affecting
changes)
- [x] Azure Verified Module updates:
- [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT
bumped the MAJOR or MINOR version in `version.json`:
- [ ] Someone has opened a bug report issue, and I have included "Closes
#{bug_report_issue_number}" in the PR description.
- [ ] The bug was found by the module author, and no one has opened an
issue to report it yet.
- [ ] Feature update backwards compatible feature updates, and I have
bumped the MINOR version in `version.json`.
- [ ] Breaking changes and I have bumped the MAJOR version in
`version.json`.
  - [ ] Update to documentation

## Checklist

- [x] I'm sure there are no other open Pull Requests for the same
update/change
- [x] I have run `Set-AVMModule` locally to generate the supporting
module files.
- [x] My corresponding pipelines / checks run clean and green without
any errors or warnings

<!-- Please keep up to date with the contribution guide at
https://aka.ms/avm/contribute/bicep -->

@jongio for notification.

---------

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AZD 🧑‍💻 These modules are requested/used by the AZD team. Class: Pattern Module 📦 This is a pattern module Language: Bicep 💪 This is related to the Bicep IaC language Status: Module Available 🟢 The module is published Status: Owners Identified 🤘 This module has its owners identified Type: New Module Proposal 💡 A new module for AVM is being proposed
Projects
5 participants