Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TF Private Endpoint interface naming update #901

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevball2
Copy link

Overview/Summary

This PR updates the resource name for the example TF PE interface to align with the names used for conditional checks in the example.

This PR fixes/adds/changes/removes

  1. Changed resource "azurerm_private_endpoint" this to resource "azurerm_private_endpoint" "this_managed_dns_zone_groups" . This changed is needed to allow for conditional checks used in the example

Breaking Changes

  1. Resource name changes will cause a redeployment of the resource.

As part of this Pull Request I have

  • Read the Contribution Guide and ensured this PR is compliant with the guide
  • Checked for duplicate Pull Requests
  • Associated it with relevant GitHub Issues or ADO Work Items (Internal Only)
  • Ensured my code/branch is up-to-date with the latest changes in the main branch
  • Ensured PR tests are passing
  • Updated relevant and associated documentation (e.g. Contribution Guide, Docs etc.)

@kevball2 kevball2 requested a review from a team as a code owner April 25, 2024 11:23
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 Maintainers need to triage still label Apr 25, 2024

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the AVM Issue Triage documentation.

Note

This label was added as per ITA06.

@matebarabas matebarabas added Language: Terraform 🌐 This is related to the Terraform IaC language Type: Documentation 📄 Improvements or additions to documentation and removed Needs: Triage 🔍 Maintainers need to triage still labels May 22, 2024
@matebarabas
Copy link
Contributor

@Azure/avm-core-team-technical-terraform, can you please take a look at this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language: Terraform 🌐 This is related to the Terraform IaC language Type: Documentation 📄 Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants