Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] move PR validation pipeline to github action #2444

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

blueww
Copy link
Member

@blueww blueww commented Aug 1, 2024

The Azure ADO pipeline will be deleted on 8/20, so move it to github action.

TODO: The "Azurite_Governance_Origin" task not converted, since not find same github action

Also deprecated node 14 since it's not in nodejs LTS matrix, and add node 22 in PR check.
#2441

Before:

Scenario/Node   14 16 18 20
Blob ubuntu-20.04  y y
  ubuntu-latest y  y
  windows-latest  y  y  
  macOS-latest y  y  
Blob-SQL ubuntu-latest  y  y
Queue ubuntu-latest  y  
  windows-latest  
  macOS-latest
Table ubuntu-latest y  
  windows-latest  y
  macOS-latest    y
VSC ubuntu-latest    y  
  windows-latest y  
  macOS-latest  y  
docker ubuntu-latest        
governance ubuntu-latest        
exe ubuntu-latest     y  
binary Test Linux ubuntu-latest     y

After the PR :

Scenario/Node   16 18 20 22
Blob ubuntu-latest y y y
  windows-latest   y  
  macOS-latest  y    y
Blob-SQL ubuntu-latest y  
Queue ubuntu-latest     y
  windows-latest  
  macOS-latest   y
Table ubuntu-latest   y
  windows-latest   y  
  macOS-latest   y
VSC ubuntu-latest  
  windows-latest     y  y
  macOS-latest   y  
docker ubuntu-latest        
exe ubuntu-latest     
binary Test Linux ubuntu-latest   y

PR Branch Destination

  • For Azurite V3, please send PR to main branch.
  • For legacy Azurite V2, please send PR to legacy-dev branch.

Always Add Test Cases

Make sure test cases are added to cover the code change.

Add Change Log

Add change log for the code change in Upcoming Release section in ChangeLog.md.

Development Guideline

Please go to CONTRIBUTION.md for steps about setting up development environment and recommended Visual Studio Code extensions.

@blueww
Copy link
Member Author

blueww commented Aug 1, 2024

The 2 failure currently is not caused by this PR, but caused by PR merge #2433 (Since this PR not really pass all validation as before pipeline it disabled).

Discussed with Xiaoning, will merge this PR now:

  1. The currently 2 failure are not caused by this PR.
  2. Merge this PR now can make sure have enough coverage on the coming PR, to avoid merge without validation happen again.
  3. We have reviewed the PR and are generally good with it.

@blueww blueww merged commit e249437 into Azure:main Aug 1, 2024
32 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants