Fix: Ncj view readme open it online (#1653)

Azure · Oct 1, 2018 · d609624 · d609624
1 parent 7500514
commit d609624
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@
 *  Unique windows show() nul pointer exception [\#1644](https://github.com/Azure/BatchExplorer/issues/1644)
 *  Reimage node is calling reboot [\#1646](https://github.com/Azure/BatchExplorer/issues/1646)
 *  Error loading metrics create null pointer exception [\#1648](https://github.com/Azure/BatchExplorer/issues/1648)
+*  View readme of NCJ application not working [\#1652](https://github.com/Azure/BatchExplorer/issues/1652)
 *  Cloning of Batch Pools does not work [\#1650](https://github.com/Azure/BatchExplorer/issues/1650)
 
 # 0.18.1

diff --git a/app/components/market/application-action/choose-action.component.ts b/app/components/market/application-action/choose-action.component.ts
@@ -41,7 +41,8 @@ export class ChooseActionComponent implements OnInit, OnDestroy {
     }
 
     @autobind()
-    public openLink(link: string) {
+    public openReadme() {
+        const link = `https://github.com/Azure/BatchExplorer-data/tree/master/ncj/${this.application.id}`;
         this.electronShell.openExternal(link, { activate: true });
     }
 

diff --git a/app/components/market/application-action/choose-action.html b/app/components/market/application-action/choose-action.html
@@ -5,8 +5,9 @@ <h1>
             <span>Action selection for
                 <span [title]="application.description">{{application?.name}}</span>
             </span>
-            <span>(
-                <a (click)="openLink(application?.readme)" href="javascript:void(0)">view readme</a>)</span>
+            <span>
+                (<bl-clickable (do)="openReadme()" href="javascript:void(0)">view readme</bl-clickable>)
+            </span>
         </h1>
         <div class="actions">
             <bl-card *ngFor="let action of actions;trackBy: trackAction" class="action">