Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot download task output files #2272

Closed
gingi opened this issue Feb 3, 2021 · 0 comments · Fixed by #2275
Closed

Cannot download task output files #2272

gingi opened this issue Feb 3, 2021 · 0 comments · Fixed by #2275
Assignees
Labels
Milestone

Comments

@gingi
Copy link
Member

gingi commented Feb 3, 2021

Describe the bug
The downloading task output files button does not work.

To Reproduce
Steps to reproduce the behavior:

  1. Navigate to a completed job task
  2. Select a file, such as "stdout.txt"
  3. Press on the 'Download' icon button
  4. Select target location
  5. Press on the 'Download' button
  6. See the error

Expected behavior
The target file to be downloaded

Screenshots
No file is downloaded

Logs(Click profile > View Logs > app.log, client.log)

DownloadButtonComponent.html:2 ERROR TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object
    at validateString (internal/validators.js:112)
    at Object.dirname (path.js:1128)
    at FileLoader.download (file-loader.ts:147)
    at FileViewerHeaderComponent._saveFile (file-viewer-header.component.ts:109)
    at FileViewerHeaderComponent.downloadFile (file-viewer-header.component.ts:77)
    at ButtonComponent._execute (button.component.ts:127)
    at ButtonComponent.handleAction (button.component.ts:105)
    at ButtonComponent.handleClick (clickable.component.ts:100)
    at Object.eval [as handleEvent] (DownloadButtonComponent.html:2)
    at handleEvent (core.js:31247)
View_DownloadButtonComponent_0 @ DownloadButtonComponent.ngfactory.js? [sm]:1
proxyClass @ compiler.js:22443
DebugContext_.logError @ core.js:32296
ErrorHandler.handleError @ core.js:4175
handleError @ error-handler.ts:15
dispatchEvent @ core.js:21512
eval @ core.js:30451
eval @ platform-browser.js:600
ZoneDelegate.invokeTask @ zone.js:421
onInvokeTask @ core.js:28120
ZoneDelegate.invokeTask @ zone.js:420
Zone.runTask @ zone.js:188
ZoneTask.invokeTask @ zone.js:503
invokeTask @ zone.js:1671
globalZoneAwareCallback @ zone.js:1697
DownloadButtonComponent.html:2 ERROR CONTEXT DebugContext_ {view: {…}, nodeIndex: 0, nodeDef: {…}, elDef: {…}, elView: {…}}
View_DownloadButtonComponent_0 @ DownloadButtonComponent.ngfactory.js? [sm]:1
proxyClass @ compiler.js:22443
DebugContext_.logError @ core.js:32296
ErrorHandler.handleError @ core.js:4180
handleError @ error-handler.ts:15
dispatchEvent @ core.js:21512
eval @ core.js:30451
eval @ platform-browser.js:600
ZoneDelegate.invokeTask @ zone.js:421
onInvokeTask @ core.js:28120
ZoneDelegate.invokeTask @ zone.js:420
Zone.runTask @ zone.js:188
ZoneTask.invokeTask @ zone.js:503
invokeTask @ zone.js:1671
globalZoneAwareCallback @ zone.js:1697
renderer-logger.ts:8 [BL] Uncaught exception: The "path" argument must be of type string. Received type object
log @ renderer-logger.ts:7
log @ renderer-logger.ts:37
error @ renderer-logger.ts:23
handleCoreError @ error-handler.ts:25
handleError @ error-handler.ts:16
dispatchEvent @ core.js:21512
eval @ core.js:30451
eval @ platform-browser.js:600
ZoneDelegate.invokeTask @ zone.js:421
onInvokeTask @ core.js:28120
ZoneDelegate.invokeTask @ zone.js:420
Zone.runTask @ zone.js:188
ZoneTask.invokeTask @ zone.js:503
invokeTask @ zone.js:1671
globalZoneAwareCallback @ zone.js:1697

Version (please complete the following information):

  • OS: Windows + MacOS
  • Version 2.8.0
@gingi gingi self-assigned this Feb 3, 2021
@cRui861 cRui861 added this to the 2.9.0 milestone Feb 3, 2021
gingi added a commit that referenced this issue Feb 4, 2021
Electron's `dialog.showSaveDialog` has changed at some point to return a `Promise` rather than a string value. Adjusted to the new API.
@gingi gingi linked a pull request Feb 4, 2021 that will close this issue
@gingi gingi added the 🐛 bug label Feb 4, 2021
gingi added a commit that referenced this issue Feb 4, 2021
Electron's `dialog.showSaveDialog` has changed at some point to return a `Promise` rather than a string value. Adjusted to the new API.
gingi added a commit that referenced this issue Feb 4, 2021
Electron's `dialog.showSaveDialog` has changed at some point to return a `Promise` rather than a string value. Adjusted to the new API.
gingi added a commit that referenced this issue Feb 4, 2021
Electron's `dialog.showSaveDialog` has changed at some point to return a `Promise` rather than a string value. Adjusted to the new API.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants