Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Show usage of quotas on pool and job page too #1098

Merged
merged 15 commits into from
Feb 27, 2018

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Feb 26, 2018

fix #1048 Show quota on job and pool page
fix #1097 Give a link to the portal support page to request for quota

Shows the quota the closest to be full by default(hovering will show others)
image

Or click to expand
image

@codecov
Copy link

codecov bot commented Feb 27, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@4f0b99a). Click here to learn what that means.
The diff coverage is 31.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1098   +/-   ##
=========================================
  Coverage          ?   53.25%           
=========================================
  Files             ?      876           
  Lines             ?    20451           
  Branches          ?     2292           
=========================================
  Hits              ?    10892           
  Misses            ?     9559           
  Partials          ?        0
Impacted Files Coverage Δ
app/services/application-service.ts 18.51% <0%> (ø)
app/services/pool.service.ts 14.08% <0%> (ø)
app/components/base/base.module.ts 95.83% <100%> (ø)
app/components/common/inline-quota/index.ts 100% <100%> (ø)
app/models/index.ts 100% <100%> (ø)
app/components/base/quotas/quotas.module.ts 100% <100%> (ø)
app/models/batch-quotas.ts 100% <100%> (ø)
app/components/base/quotas/index.ts 100% <100%> (ø)
app/components/common/index.ts 100% <100%> (ø)
app/services/index.ts 100% <100%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f0b99a...322b51e. Read the comment docs.

@timotheeguerin timotheeguerin merged commit ea8aa08 into master Feb 27, 2018
@timotheeguerin timotheeguerin deleted the feature/quota-on-other-pages branch February 27, 2018 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Give an option to request more quota Show quotas on respective pages
1 participant