Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Moved main logger in @batch-flask #1110

Merged
merged 10 commits into from
Mar 3, 2018

Conversation

timotheeguerin
Copy link
Member

fix #1108

@codecov
Copy link

codecov bot commented Mar 3, 2018

Codecov Report

Merging #1110 into master will increase coverage by <.01%.
The diff coverage is 80.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1110      +/-   ##
==========================================
+ Coverage   53.37%   53.37%   +<.01%     
==========================================
  Files         891      890       -1     
  Lines       20546    20531      -15     
  Branches     2289     2290       +1     
==========================================
- Hits        10966    10958       -8     
+ Misses       9580     9573       -7
Impacted Files Coverage Δ
app/utils/index.ts 100% <ø> (ø) ⬆️
.../components/file/details/file-content.component.ts 94.28% <100%> (ø) ⬆️
...action/scale/autoscale-formula-picker.component.ts 16.66% <100%> (ø) ⬆️
app/services/predefined-formula.service.ts 26.66% <100%> (ø) ⬆️
app/services/settings.service.ts 17.77% <100%> (ø) ⬆️
src/@batch-flask/ui/sidebar/sidebar-content.ts 97.36% <100%> (ø) ⬆️
src/@batch-flask/ui/table/table.component.ts 63.01% <100%> (-0.5%) ⬇️
src/@batch-flask/ui/tags/tags.component.ts 87.17% <100%> (ø) ⬆️
app/utils/arm-resource-utils/arm-resource-utils.ts 86.66% <100%> (ø) ⬆️
src/@batch-flask/utils/index.ts 100% <100%> (ø) ⬆️
... and 25 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 369fd54...e6dd63e. Read the comment docs.

@timotheeguerin timotheeguerin merged commit f63495a into master Mar 3, 2018
@timotheeguerin timotheeguerin deleted the internal/logger-flask branch March 3, 2018 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move logger to @batch-flask package
1 participant