Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Task filter broken and clicking on filter task from job details(Same for node from pool) #1159

Merged
merged 6 commits into from
Mar 14, 2018

Conversation

timotheeguerin
Copy link
Member

fix #1158 (Task Filter not applying)
fix #1155 (Node and task filter from pool and job ui broken)

@codecov
Copy link

codecov bot commented Mar 14, 2018

Codecov Report

Merging #1159 into master will decrease coverage by <.01%.
The diff coverage is 18.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1159      +/-   ##
==========================================
- Coverage   53.67%   53.66%   -0.01%     
==========================================
  Files         931      929       -2     
  Lines       20949    20948       -1     
  Branches     2330     2331       +1     
==========================================
- Hits        11244    11242       -2     
- Misses       9705     9706       +1
Impacted Files Coverage Δ
app/services/task.service.ts 12.85% <ø> (ø)
app/services/core/data/entity-getter.ts 94.11% <0%> (ø) ⬆️
app/services/file-service.ts 12.63% <0%> (ø) ⬆️
...-flask/ui/browse-layout/browse-layout.component.ts 18.55% <0%> (-0.2%) ⬇️
app/services/index.ts 100% <100%> (ø) ⬆️
...sk/browse/filter/task-advanced-filter.component.ts 60% <50%> (ø) ⬆️
...nents/pool/action/add/license-eula-dialog/index.ts
...onents/pool/action/add/app-license-picker/index.ts
...app-license-picker/app-license-picker.component.ts
...cense-eula-dialog/license-eula-dialog.component.ts
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 311404a...fd43ae4. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 6acc4a5 into master Mar 14, 2018
@timotheeguerin timotheeguerin deleted the fix/task-filter branch March 14, 2018 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task advanced filter is not applying Clicking on the task filter from job details crash
1 participant