Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Certificate reference picker #1210

Merged
merged 10 commits into from
Mar 26, 2018
Merged

Feature: Certificate reference picker #1210

merged 10 commits into from
Mar 26, 2018

Conversation

johnnyzhang82
Copy link
Contributor

Fixed #1194

  1. added certificate reference picker in create pool form
  2. use a new button for certificate/app package upload button
  3. fixed some misc issues

Certificate reference picker interface
image

Inner certificate reference interface
image

New upload certificate
image

New upload app package button
image

@johnnyzhang82 johnnyzhang82 changed the title Feature/cert ref Feature: Certificate reference picker Mar 23, 2018
@codecov
Copy link

codecov bot commented Mar 23, 2018

Codecov Report

Merging #1210 into master will decrease coverage by 0.14%.
The diff coverage is 32.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1210      +/-   ##
==========================================
- Coverage   53.38%   53.23%   -0.15%     
==========================================
  Files         946      948       +2     
  Lines       21538    21656     +118     
  Branches     2394     2413      +19     
==========================================
+ Hits        11497    11528      +31     
- Misses      10041    10128      +87
Impacted Files Coverage Δ
app/models/forms/create-pool-model.ts 17.5% <0%> (-1.42%) ⬇️
...count/action/add/batch-account-create.component.ts 73.98% <0%> (ø) ⬆️
src/@batch-flask/core/record/navigable-record.ts 100% <100%> (ø) ⬆️
app/components/pool/action/add/index.ts 100% <100%> (ø) ⬆️
...inned-entity-dropdown/pinned-dropdown.component.ts 81.03% <100%> (ø) ⬆️
...nts/pool/action/add/certificate-reference/index.ts 100% <100%> (ø)
app/services/pinned-entity.service.ts 97.46% <100%> (ø) ⬆️
...l/action/add/pool-create-basic-dialog.component.ts 12.38% <15.38%> (-1.45%) ⬇️
...tificate-reference/certificate-picker.component.ts 28.28% <28.28%> (ø)
...tch-flask/ui/buttons/directory-picker.component.ts 31.57% <33.33%> (+0.32%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3109caa...f54807e. Read the comment docs.

@johnnyzhang82 johnnyzhang82 merged commit ad0fcd6 into master Mar 26, 2018
@johnnyzhang82 johnnyzhang82 deleted the feature/certRef branch March 26, 2018 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a certificate reference to a pool
1 participant