Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Select V1.1 #1262

Merged
merged 16 commits into from
Apr 12, 2018
Merged

Feature: Select V1.1 #1262

merged 16 commits into from
Apr 12, 2018

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Apr 11, 2018

@timotheeguerin timotheeguerin changed the title Feature: Select v2 Feature: Select V1.1 Apr 11, 2018
@codecov
Copy link

codecov bot commented Apr 12, 2018

Codecov Report

Merging #1262 into master will increase coverage by 0.18%.
The diff coverage is 84.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1262      +/-   ##
==========================================
+ Coverage   53.35%   53.54%   +0.18%     
==========================================
  Files         959      961       +2     
  Lines       22177    22267      +90     
  Branches     2481     2491      +10     
==========================================
+ Hits        11833    11922      +89     
- Misses      10344    10345       +1
Impacted Files Coverage Δ
...rc/@batch-flask/ui/select/select-dropdown/index.ts 100% <100%> (ø)
src/@batch-flask/ui/select/select.module.ts 100% <100%> (ø) ⬆️
app/services/themes/theme.model.ts 74.44% <63.63%> (-0.56%) ⬇️
...elect/select-dropdown/select-dropdown.component.ts 79.48% <79.48%> (ø)
src/@batch-flask/ui/select/select.component.ts 75.62% <90%> (+12.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9716a34...92818d4. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 5a63ef5 into master Apr 12, 2018
@timotheeguerin timotheeguerin deleted the feature/select-v2 branch April 12, 2018 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select dropdown not showing when parent has overflow hidden bl-select always defaults to focusFirstOption()
1 participant