Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode parameters passed into application #1365

Merged
merged 4 commits into from
May 24, 2018
Merged

Conversation

ascobie
Copy link
Member

@ascobie ascobie commented May 23, 2018

Fix: #1364

@codecov
Copy link

codecov bot commented May 23, 2018

Codecov Report

Merging #1365 into master will decrease coverage by <.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
- Coverage   53.49%   53.49%   -0.01%     
==========================================
  Files        1002     1002              
  Lines       23651    23653       +2     
  Branches     2704     2704              
==========================================
+ Hits        12653    12654       +1     
- Misses      10998    10999       +1
Impacted Files Coverage Δ
app/services/navigator.service.ts 29.62% <33.33%> (+1.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 555d378...2090a7a. Read the comment docs.

package.json Outdated
@@ -136,6 +136,7 @@
"chokidar": "~2.0.0",
"commander": "~2.13.0",
"d3": "~4.12.2",
"decode-uri-component": "^0.2.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you change to ~ instead of ^, even though it is locked it shows differently that way when they push a minor version vs a patch

@ascobie ascobie merged commit e2ad83e into master May 24, 2018
@ascobie ascobie deleted the fix/decode-url-params branch May 24, 2018 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants