Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Tags keyboard navigation and OnPush change detection #1421

Merged
merged 11 commits into from
Jun 10, 2018

Conversation

timotheeguerin
Copy link
Member

fix #1420

@codecov
Copy link

codecov bot commented Jun 9, 2018

Codecov Report

Merging #1421 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1421      +/-   ##
=========================================
+ Coverage   53.64%   53.7%   +0.06%     
=========================================
  Files        1023    1025       +2     
  Lines       24307   24333      +26     
  Branches     2800    2800              
=========================================
+ Hits        13040   13069      +29     
+ Misses      11267   11264       -3
Impacted Files Coverage Δ
...batch-flask/ui/tags/tag-list/tag-list.component.ts 100% <100%> (ø)
src/@batch-flask/ui/tags/tags.module.ts 100% <100%> (ø) ⬆️
src/@batch-flask/ui/tags/tags.component.ts 95.74% <100%> (+8.56%) ⬆️
src/@batch-flask/ui/tags/tag-list/index.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aea524a...6278417. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 370bf7e into master Jun 10, 2018
@timotheeguerin timotheeguerin deleted the a11y/tags branch June 10, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags are not accessible via keyboard
1 participant