Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: File service call api directly(no sdk) #1462

Merged
merged 9 commits into from
Jun 22, 2018

Conversation

timotheeguerin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #1462 into master will increase coverage by 0.18%.
The diff coverage is 42.03%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1462      +/-   ##
=========================================
+ Coverage   57.12%   57.3%   +0.18%     
=========================================
  Files        1054    1054              
  Lines       24754   24749       -5     
  Branches     3411    3406       -5     
=========================================
+ Hits        14140   14182      +42     
+ Misses      10614   10567      -47
Impacted Files Coverage Δ
app/services/index.ts 100% <ø> (ø) ⬆️
app/services/batch-api/batch-client-proxy.ts 25% <ø> (ø) ⬆️
app/services/azure-batch/pool/pool.service.ts 71.42% <100%> (ø) ⬆️
app/models/file-properties.ts 100% <100%> (ø) ⬆️
app/services/azure-batch/core/batch-list-getter.ts 76.92% <100%> (ø) ⬆️
app/services/azure-batch/file/index.ts 100% <100%> (ø)
app/services/azure-batch/index.ts 100% <100%> (ø) ⬆️
app/services/azure-batch/file/file.service.ts 38.19% <38.19%> (ø)
...p/services/azure-batch/core/batch-entity-getter.ts 83.33% <71.42%> (-8.34%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60f8fda...6fecb8c. Read the comment docs.

@timotheeguerin timotheeguerin merged commit d481282 into master Jun 22, 2018
@timotheeguerin timotheeguerin deleted the internal/file-no-sdk branch June 22, 2018 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant