Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency injection in the client process #1471

Merged
merged 10 commits into from
Jun 28, 2018
Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jun 27, 2018

fix #1470

Todo:

  • BLIpcMain as a service
  • LocalStorage interface and move AccessTokenCache to @batch-flask

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #1471 into master will increase coverage by 0.16%.
The diff coverage is 80%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1471      +/-   ##
=========================================
+ Coverage   58.74%   58.9%   +0.16%     
=========================================
  Files        1047    1050       +3     
  Lines       24561   24582      +21     
  Branches     3387    3386       -1     
=========================================
+ Hits        14428   14480      +52     
+ Misses      10133   10102      -31
Impacted Files Coverage Δ
src/common/constants/constants.ts 100% <ø> (ø) ⬆️
app/services/adal/adal.service.ts 89.13% <100%> (-0.24%) ⬇️
.../@batch-flask/core/aad/access-token-cache/index.ts 100% <100%> (ø)
src/@batch-flask/core/aad/index.ts 100% <100%> (ø) ⬆️
src/@batch-flask/core/data-store/index.ts 100% <100%> (ø)
src/@batch-flask/core/index.ts 100% <100%> (ø) ⬆️
src/@batch-flask/core/constants.ts 100% <100%> (ø) ⬆️
...atch-flask/core/data-store/in-memory-data-store.ts 66.66% <66.66%> (ø)
.../core/aad/access-token-cache/access-token-cache.ts 88.52% <87.5%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a11064...9b9440b. Read the comment docs.

@timotheeguerin timotheeguerin merged commit fdd2cf4 into master Jun 28, 2018
@timotheeguerin timotheeguerin deleted the feature/di-client branch June 28, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add some dependency injection logic in client process
1 participant