Feature: Job task counts shows warning if not validated #1476
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1476 +/- ##
=========================================
+ Coverage 58.9% 58.9% +<.01%
=========================================
Files 1050 1050
Lines 24582 24584 +2
Branches 3386 3386
=========================================
+ Hits 14480 14482 +2
Misses 10102 10102
Continue to review full report at Codecov.
|
| expect(warning).toBeFalsy(); | ||
| }); | ||
|
|
||
| it("show warning about task count validity if count is unvalidated", () => { |
There was a problem hiding this comment.
is there already a warning if the # of tasks > 200000? https://docs.microsoft.com/en-us/azure/batch/batch-get-task-counts
There was a problem hiding this comment.
It doesn't, we talked about this at lunch, the problem also is how do we know if there is more than 200k tasks if it can't count it.
The idea was maybe to disable the gauge if it was over 200k
There was a problem hiding this comment.
It is not "can't count" it is "not accurate". I think it is fair to add up the #s and show a warning if the result is >150000. Give that sort of thing some thought.
There was a problem hiding this comment.
I'll append to the warning if total count is close to 200k
There was a problem hiding this comment.
Try to choose a phrase from the feature article. The feature has a very complicated consistency model.
There was a problem hiding this comment.
We can chat in person as well... Ideally the text would match what we surface in the portal.
fix #1475