Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Job graph cancel list all #1478

Merged
merged 6 commits into from
Jul 3, 2018
Merged

Conversation

timotheeguerin
Copy link
Member

@timotheeguerin timotheeguerin commented Jun 29, 2018

fix #1472

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #1478 into master will decrease coverage by 0.03%.
The diff coverage is 37.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1478      +/-   ##
==========================================
- Coverage   59.01%   58.98%   -0.04%     
==========================================
  Files        1050     1051       +1     
  Lines       24629    24649      +20     
  Branches     3395     3400       +5     
==========================================
+ Hits        14534    14538       +4     
- Misses      10095    10111      +16
Impacted Files Coverage Δ
app/services/core/data/list-getter/index.ts 100% <100%> (ø)
app/services/core/data/list-getter/list-getter.ts 100% <100%> (ø)
...raphs/job-graphs-home/job-graphs-home.component.ts 21.92% <12.82%> (-2.08%) ⬇️
...sk/ui/buttons/refresh-btn/refresh-btn.component.ts 39.39% <20%> (-3.94%) ⬇️
...b-progress-status/job-progress-status.component.ts 97.8% <83.33%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e319c5a...81c7f23. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 32fa1db into master Jul 3, 2018
@timotheeguerin timotheeguerin deleted the fix/job-graph-cancel-list-all branch July 3, 2018 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task timeline doesn't cancel requests when leaving component
1 participant