Feature: Setup vsts builds & switch from yarn to npm 5

.travis.yml

@@ -19,24 +19,7 @@ python:
   - "3.6"
 
 matrix:
-  fast_finish: true
-  allow_failures:
-    os: osx # This allows not to wait for the osx build to be scheduled
-
   include:
-    - language: generic
-      os: osx
-      before_install:
-        - brew update
-        - brew upgrade python
-        - brew install python@2
-        - python --version
-        - python3 --version
-        - which python
-        - npm config set python python2.7
-        - nvm install 9.6.1
-        - nvm use 9.6.1
-
     - language: node_js
       os: linux
       services: docker
@@ -53,10 +36,9 @@ matrix:
         - sleep 3
 
 install:
-  - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then /sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen 0 1280x1024x16; fi
+  - /sbin/start-stop-daemon --start --quiet --pidfile /tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen 0 1280x1024x16
   - npm install -g codecov
-  - npm install -g yarn
-  - yarn --ignore-engines install
+  - npm install
   - python3 --version
   - pip3 install -r python/requirements.txt
 
@@ -68,7 +50,6 @@ branches:
   only:
   - master
   - stable
-  - fix/publish
 
 cache:
   # yarn: true

.vsts/dependencies.yml

@@ -0,0 +1,4 @@
+steps:
+  - task: NodeTool@0
+    inputs:
+      versionSpec: '8.11.x'

.vsts/pipelines.yml

@@ -0,0 +1,97 @@
+name: $(SourceBranch)$(Rev:.r)
+phases:
+  - phase: Linux
+    queue: Hosted Linux Preview
+    steps:
+    - script: |
+        set -e
+        apt-get update
+        apt-get install -y libxkbfile-dev pkg-config libsecret-1-dev libxss1 libgconf-2-4 dbus xvfb libgtk-3-0
+      displayName: Install Linux packages
+    - template: ./dependencies.yml
+    - template: ./pyenv.yml
+    - script: |
+        set -e
+        python --version
+        npm install -g codecov
+        npm install
+        pip3 install -r python/requirements.txt
+      displayName: Install dependencies
+
+    - script: |
+        export DISPLAY=:99
+        xvfb-run npm run test
+      displayName: Run tests
+
+    - task: PublishTestResults@2
+      inputs:
+        testRunner: 'JUnit'
+        testResultsFiles: $(System.DefaultWorkingDirectory)/coverage/TESTS*.xml
+
+    - task: PublishCodeCoverageResults@1
+      inputs:
+        codeCoverageTool: cobertura
+        summaryFileLocation: $(System.DefaultWorkingDirectory)/coverage/cobertura.xml
+        reportDirectory: $(System.DefaultWorkingDirectory)/coverage/html
+
+    - script: npm run build-and-pack
+      displayName: Build and pack
+
+    - script: npm run lint
+      displayName: Lint
+
+    - task: PublishBuildArtifacts@1
+      displayName: Publish artifacts
+      inputs:
+        pathtoPublish: ./release
+        artifactName: linux
+        artifactType: Container
+
+  # Mac os build
+  - phase: macOS
+    queue: Hosted macOS Preview
+    steps:
+    - template: ./dependencies.yml
+    - script: npm config set python $(which python)
+      displayName: Set npm python2 path
+    - template: ./pyenv.yml
+    - script: |
+        set -e
+        node --version
+        npm config list
+        npm install
+        pip install -r python/requirements.txt
+      displayName: Install dependencies
+
+    - script: npm run build-and-pack
+      displayName: Build and pack
+
+    - task: PublishBuildArtifacts@1
+      displayName: Publish artifacts
+      inputs:
+        pathtoPublish: ./release
+        artifactName: osx
+        artifactType: Container
+
+  - phase: Windows
+    queue: Hosted VS2017
+    steps:
+      - template: ./dependencies.yml
+      - task: UsePythonVersion@0
+        inputs:
+          versionSpec: '3.6.x'
+      - powershell: |
+          node --version
+          npm install
+          pip install -r python/requirements.txt
+        displayName: Install dependencies
+
+      - powershell: npm run build-and-pack
+        displayName: Build and pack
+
+      - task: PublishBuildArtifacts@1
+        displayName: Publish artifacts
+        inputs:
+          pathtoPublish: ./release
+          artifactName: windows
+          artifactType: Container

.vsts/pyenv.yml

@@ -0,0 +1,14 @@
+steps:
+  - script: |
+      set -e
+      export PYENV_ROOT="$(Agent.WorkFolder)/.pyenv"
+      git clone https://github.com/pyenv/pyenv.git $PYENV_ROOT
+      export PATH="$PYENV_ROOT/bin:$PATH"
+      pyenv --version
+      PYTHON_CONFIGURE_OPTS="--enable-shared" pyenv install 3.6.6
+      pyenv global 3.6.6
+      python --version
+      echo "Path is $PATH"
+      echo "##vso[task.prependpath]$PYENV_ROOT/bin"
+      echo "##vso[task.prependpath]$PYENV_ROOT/shims"
+    displayName: Install python

Readme.md

@@ -17,7 +17,7 @@ You can download the latest version at https://github.com/Azure/BatchLabs/releas
 
 ## Building batchlabs yourself
 #### 1. Prerequisites
-- **Install node.js version `6.9` or greater. [Download](https://nodejs.org/en/download/)**
+- **Install node.js version `8` or greater. [Download](https://nodejs.org/en/download/)**
 - Install python **3.6** (doesn't need to be in the path if that breaks your environment)
 
 #### 2. Clone the repo
@@ -35,11 +35,9 @@ Call this command and it will check you have everything setup correctly and buil
 
 #### 4. Install the dependencies
 ```bash
-npm install -g yarn
-yarn install
+npm install
 pip3 install -r python/requirements.txt # or pip if on windows or only have python 3.6 installed
 ```
-Note: You can also use `npm install` at your own risk. However please do not submit an issue if you didn't use `yarn install`. Yarn will make sure you have the right set of dependencies, which reduces the likelihood of any unexpected build issues relating to third party packages.
 
 #### 4.5 Setup some configuration(Only in certain case)
 If you didn't installed python in the path you will need to let batchlabs know where it is.

appveyor.yml

@@ -22,18 +22,13 @@ install:
 
   - ps: Install-Product node 8.9.1 x64
   - npm install -g npm -s
-  - npm install -g yarn -s
-  - yarn install --force
+  - npm install
   - pip install -r python/requirements.txt
 
 build_script:
     - npm run -s build:prod
     - npm run -s build-python
-    - IF [%APPVEYOR_REPO_BRANCH%]==[stable] (
-        npm run -s package -- --publish always --draft --win
-      ) ELSE (
-        npm run -s package -- --publish never
-      )
+    - npm run -s package -- --publish never
 
 test_script:
     # - npm run test -s
@@ -43,4 +38,4 @@ artifacts:
     name: Batchlabs-windows-setup.exe
   - path: release\*win.zip
     name: Batchlabs-windows.zip
-    
+

docs/setup.md

@@ -4,7 +4,7 @@
 ## 1. Prerequisites
 Follow the **Building batchlabs yourself** instruction of the [main readme](../Readme.md) in order to install all require dependencies.
 
-**Use `yarn install` instead of `npm install`. This ensures a consistent build environment with the right set of dependencies [Migrating from npm to yarn](https://yarnpkg.com/lang/en/docs/migrating-from-npm/)**
+**Use `npm` 5 and above. This ensures a consistent build environment with the right set of dependencies**
 
 Start the dev server
 ```bash

karma.conf.js

@@ -3,7 +3,8 @@ const webpackConfig = require("./config/webpack.config.test");
 process.env.ELECTRON_DISABLE_SECURITY_WARNINGS = "true";
 
 // Only enable coverage if env is defined(So we don't enable it in watch mode as it duplicate logs)
-const coverageReporters = process.env.COVERAGE ? ["coverage", "remap-coverage"] : [];
+const coverageReporters = process.env.COVERAGE ? ["coverage", "remap-coverage", "junit"] : [];
+
 // Karma config for testing the code running the browser environemnt.
 // For the client testing use the mocha command line.
 module.exports = function(config) {
@@ -82,7 +83,12 @@ module.exports = function(config) {
         remapCoverageReporter: {
             "text-summary": null,
             json: "./coverage/coverage.json",
-            html: "./coverage/html"
+            html: "./coverage/html",
+            cobertura: "./coverage/cobertura.xml",
         },
+        // Can't enable yet has a conflict in dependency with azure-storage
+        junitReporter: {
+            outputDir: "./coverage"
+        }
     });
 };