Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessiblity: Img tags missing alt tags + tests #1483

Merged
merged 4 commits into from
Jul 5, 2018

Conversation

timotheeguerin
Copy link
Member

fix #1482

@codecov
Copy link

codecov bot commented Jul 5, 2018

Codecov Report

Merging #1483 into master will increase coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1483      +/-   ##
==========================================
+ Coverage   59.05%   59.06%   +<.01%     
==========================================
  Files        1053     1053              
  Lines       24696    24708      +12     
  Branches     3414     3414              
==========================================
+ Hits        14585    14593       +8     
- Misses      10111    10115       +4
Impacted Files Coverage Δ
...s/image-file-viewer/image-file-viewer.component.ts 100% <100%> (+4.34%) ⬆️
app/services/file/file-loader.ts 12.5% <11.76%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771472c...4b57d27. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 59acc62 into master Jul 5, 2018
@timotheeguerin timotheeguerin deleted the a11y/file-viewer-alt-tag branch July 5, 2018 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images tags are missing alt attributes
1 participant