Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Pick which branch to load the github data from #1491

Merged
merged 6 commits into from
Jul 9, 2018

Conversation

timotheeguerin
Copy link
Member

fix #1474

@codecov
Copy link

codecov bot commented Jul 9, 2018

Codecov Report

Merging #1491 into master will increase coverage by 0.14%.
The diff coverage is 60.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1491      +/-   ##
==========================================
+ Coverage    59.2%   59.34%   +0.14%     
==========================================
  Files        1053     1054       +1     
  Lines       24738    24770      +32     
  Branches     3418     3425       +7     
==========================================
+ Hits        14645    14699      +54     
+ Misses      10093    10071      -22
Impacted Files Coverage Δ
app/services/index.ts 100% <100%> (ø) ⬆️
app/services/github-data/index.ts 100% <100%> (ø)
app/services/predefined-formula.service.ts 26.66% <20%> (ø) ⬆️
app/services/vm-size.service.ts 20.96% <25%> (ø) ⬆️
app/services/ncj-template.service.ts 18.39% <29.03%> (+4.21%) ⬆️
app/services/github-data/github-data.service.ts 76.25% <76.25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44a7f1b...bd82949. Read the comment docs.

@timotheeguerin timotheeguerin merged commit 41c6660 into master Jul 9, 2018
@timotheeguerin timotheeguerin deleted the feature/github-data-branch-setting branch July 9, 2018 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to override the BatchLabs-data branch that we pull templates from
1 participant