Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Support internationalization #1500

Merged
merged 31 commits into from
Jul 26, 2018
Merged

Feature: Support internationalization #1500

merged 31 commits into from
Jul 26, 2018

Conversation

timotheeguerin
Copy link
Member

fix #1499

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #1500 into master will increase coverage by 0.08%.
The diff coverage is 91.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
+ Coverage   60.24%   60.33%   +0.08%     
==========================================
  Files        1054     1065      +11     
  Lines       24823    24888      +65     
  Branches     3434     3437       +3     
==========================================
+ Hits        14954    15015      +61     
- Misses       9869     9873       +4
Impacted Files Coverage Δ
app/services/themes/theme.service.ts 18.6% <ø> (+0.21%) ⬆️
...sk/ui/duration-picker/duration-picker.component.ts 88.96% <ø> (ø) ⬆️
app/services/batch-labs.service.ts 15.15% <0%> (+2.65%) ⬆️
src/@batch-flask/core/index.ts 100% <100%> (ø) ⬆️
src/@batch-flask/ui/i18n/i18n-ui.module.ts 100% <100%> (ø)
src/@batch-flask/ui/i18n/i18n.pipe.ts 100% <100%> (ø)
app/services/index.ts 100% <100%> (ø) ⬆️
src/@batch-flask/core/i18n/index.ts 100% <100%> (ø)
...flask/ui/duration-picker/duration-picker.module.ts 100% <100%> (ø) ⬆️
src/@batch-flask/ui/index.ts 100% <100%> (ø) ⬆️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b5a08...e9da5b6. Read the comment docs.

@timotheeguerin timotheeguerin merged commit d42ff2a into master Jul 26, 2018
@timotheeguerin timotheeguerin deleted the feature/i18n branch July 26, 2018 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support internationalization
1 participant