Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show password to user on node connect form #1533

Merged
merged 3 commits into from
Aug 3, 2018

Conversation

arinehouse
Copy link
Contributor

Closes #1532

@arinehouse arinehouse changed the title Show password to user on node connect form Fix: Show password to user on node connect form Aug 3, 2018
@arinehouse arinehouse changed the title Fix: Show password to user on node connect form Fix:Show password to user on node connect form Aug 3, 2018
@timotheeguerin timotheeguerin changed the title Fix:Show password to user on node connect form Fix: Show password to user on node connect form Aug 3, 2018
@codecov
Copy link

codecov bot commented Aug 3, 2018

Codecov Report

Merging #1533 into stable will decrease coverage by <.01%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff            @@
##           stable   #1533      +/-   ##
=========================================
- Coverage    60.9%   60.9%   -0.01%     
=========================================
  Files        1077    1077              
  Lines       25282   25316      +34     
  Branches     3505    3511       +6     
=========================================
+ Hits        15399   15419      +20     
- Misses       9883    9897      +14
Impacted Files Coverage Δ
src/@batch-flask/ui/electron/clipboard.service.ts 25% <0%> (ø) ⬆️
...roperty-display/node-property-display.component.ts 67.9% <56.25%> (-4.83%) ⬇️
.../components/node/connect/node-connect.component.ts 82.96% <71.42%> (-1.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c62c05...90f8bfe. Read the comment docs.

@timotheeguerin timotheeguerin merged commit fb66849 into stable Aug 3, 2018
@timotheeguerin timotheeguerin deleted the fix/node-connect-display-password branch August 3, 2018 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants